Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

VMCI failures are all reported as "code: -1. can't connect to ESX". #206

Closed
msterin opened this issue Mar 25, 2016 · 0 comments · Fixed by #435
Closed

VMCI failures are all reported as "code: -1. can't connect to ESX". #206

msterin opened this issue Mar 25, 2016 · 0 comments · Fixed by #435
Assignees
@msterin
Labels
P1
Milestone
v1 TP

Comments

@msterin
Copy link
Contributor

msterin commented Mar 25, 2016 •
edited

Both vmci_client.c and vmci_server.c return "-1" on any error, and we report it to user (and log) as "Can't connect to ESX" or "Peer connection dropped".

Error code is now passed back in VMCI packet, and if empty string is passed it's considered Success.
At a minimum, this API and error handling has to be documented and the error string needs to be bubbled up to logs

/CC @govint
@msterin msterin added the P1 label Mar 25, 2016
@msterin msterin added this to the TP milestone Mar 25, 2016
msterin pushed a commit that referenced this issue Mar 25, 2016
Cleanup of TODO and rename of python tests
4d17e3d 
- removed useless TODOs. The majority of them are resolved,
and for those not resolved new issued are created (e.g. #205 #206)
- renamed tests_*.py to *_test.py to make consistent with go tests,
which are always named *_test.go (enforced by 'go test')
@msterin msterin mentioned this issue Mar 25, 2016
Merged
msterin pushed a commit that referenced this issue Mar 28, 2016
Cleanup of TODO and rename of python tests
4295320 
- removed useless TODOs. The majority of them are resolved,
and for those not resolved new issued are created (e.g. #205 #206)
- renamed tests_*.py to *_test.py to make consistent with go tests,
which are always named *_test.go (enforced by 'go test')
@msterin msterin changed the title Clean up and formalize network API and error code passing to client, and report to GO API VMCI failures are all reported as "code: -1. can't connect to ESX". Apr 29, 2016
@msterin msterin modified the milestones: v1 GA, TP Apr 29, 2016
@msterin msterin modified the milestones: v1 TP, v1 GA May 31, 2016
@msterin msterin self-assigned this May 31, 2016
msterin pushed a commit that referenced this issue Jun 2, 2016
Report errno and proper strings on vSocket communcation failures
134256c 
Fixes #206

* Client code passes errno up and GO code handles it.
  CGO auto0-returns (return, error) tuple and error info was there all along, we just use it now.
* Server code makes sure  errno is properly set (and not cleaned up by close() and the likes) ,
  and sets errno when needed. Python code then generates proper messages
* removed uneeded custom error codes - it turned out to be throwaway code
* a few cosmetic changes - mainly dropped single letter variables since they are hard to  maintain
msterin pushed a commit that referenced this issue Jun 2, 2016
Report errno and proper strings on vSocket communcation failures
0b3e7d9 
Fixes #206

* Client code passes errno up and GO code handles it.
  CGO auto0-returns (return, error) tuple and error info was there all along, we just use it now.
* Server code makes sure  errno is properly set (and not cleaned up by close() and the likes) ,
  and sets errno when needed. Python code then generates proper messages
* removed uneeded custom error codes - it turned out to be throwaway code
* a few cosmetic changes - mainly dropped single letter variables since they are hard to  maintain
@msterin msterin mentioned this issue Jun 2, 2016
Merged
msterin pushed a commit that referenced this issue Jun 2, 2016
Report errno and proper strings on vSocket communcation failures
36c8226 
Fixes #206

* Client code passes errno up and GO code handles it.
  CGO auto0-returns (return, error) tuple and error info was there all along, we just use it now.
* Server code makes sure  errno is properly set (and not cleaned up by close() and the likes) ,
  and sets errno when needed. Python code then generates proper messages
* removed uneeded custom error codes - it turned out to be throwaway code
* a few cosmetic changes - mainly dropped single letter variables since they are hard to  maintain
msterin pushed a commit that referenced this issue Jun 2, 2016
Report errno and proper strings on vSocket communcation failures (#435)
e1da74b 
* Report errno and proper strings on vSocket communcation failures

Fixes #206

* Client code passes errno up and GO code handles it.
  CGO auto0-returns (return, error) tuple and error info was there all along, we just use it now.
* Server code makes sure  errno is properly set (and not cleaned up by close() and the likes) ,
  and sets errno when needed. Python code then generates proper messages
* removed uneeded custom error codes - it turned out to be throwaway code
* a few cosmetic changes - mainly dropped single letter variables since they are hard to  maintain

* Review comments addressed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@msterin msterin

Labels
P1
Projects
None yet
Milestone
v1 TP
1 participant
@msterin