Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Update documentation and demos for file system format option #604

Closed
kerneltime opened this issue Sep 21, 2016 · 5 comments
Closed

Update documentation and demos for file system format option #604

kerneltime opened this issue Sep 21, 2016 · 5 comments

Comments

@kerneltime
Copy link
Contributor

Documentation and demos need updating post #597 merge

@brunotm
Copy link
Contributor

brunotm commented Sep 23, 2016

@kerneltime
There is more documents needing an update other than README.md?

@kerneltime
Copy link
Contributor Author

Yup. https://vmware.github.io/docker-volume-vsphere/ content needs updating which gets generated from https://github.com/vmware/docker-volume-vsphere/tree/master/docs. We will be cutting a release on the 28th, if it is not done by then I will do it as part of the release.

@brunotm
Copy link
Contributor

brunotm commented Sep 23, 2016

I will look into it.
Should #35 also be closed after #597 merge? Found it in the README.md and remember @msterin commenting something about a similar issue.

Edit:
After reading the whole #35 issue, maybe only remove it from the README.md ?

@msterin
Copy link
Contributor

msterin commented Sep 23, 2016

@brunotm - unfortunately #35 is still valid. #597 makes it low(er) priority - before your fix create of a large volume blocked ALL plugins on the given ESX host for the time it took to format the volume. Now, it only blocks an individual Docker engine plugin, but other Docker VMs are fine.
Still, everything is serialized per Docker engine, and other ops are serialized globally.

Readme.md can be slightly adjusted to say "when large volume is formatted, all plugin operations on the same Docker engine will be serialized behind it" or simply "will wait for completion"; but the note is still valid.

@kerneltime
Copy link
Contributor Author

Fixed in #605

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants