Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Correct printing of error info message for docker volume create command #1004

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

pshahzeb
Copy link
Contributor

@pshahzeb pshahzeb commented Mar 7, 2017

zip() function in python3 returns an iterator. So creating a list from it for
proper error info message printing for docker volume create command

Resolves: #1002

After fix:

root@photon-xVmYMbyTn [ ~ ]# docker volume create --driver=vsphere --name abc334@vsanDatastore -o size=1MB -o vsan-policy-na=abc
Error response from daemon: create abc334@vsanDatastore: VolumeDriver.Create: Invalid options: ['vsan-policy-na']
Valid options and defaults: [('size', '100mb'), ('vsan-policy-name', '[VSAN default]'), ('diskformat', 'thin'), ('attach-as', 'independent_persistent'), ('access', 'read-write'), ('fstype', 'ext4'), ('clone-from', 'None')]

Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works with Python 2 as well rt?

@pshahzeb
Copy link
Contributor Author

pshahzeb commented Mar 8, 2017

@pdhamdhere Yes it does.

zip() function in python3 returns an iterator. So creating a list from it for
proper error info message printing for docker volume create command

Resolves: #1002
@shuklanirdesh82 shuklanirdesh82 merged commit baa5353 into master Mar 9, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the issue_1002.pshahzeb branch March 9, 2017 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corrupted reply mesage to a typo in docker volume create command
5 participants