This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Detach after mount failure, and a small fix for logs #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 7, 2017 17:37
Also make us a little bit more patient on slow disk attach (may happen due to slow VM reconfig on overloaded system)
pdhamdhere
reviewed
Mar 8, 2017
| refcnt, _ := d.decrRefCount(r.Name) | ||
| if refcnt == 0 { | ||
| log.Infof("Detaching %s - it is not used anymore", r.Name) | ||
| d.ops.Detach(r.Name, nil) // try to detach before failing the request for volume |
There was a problem hiding this comment.
Should you be calling "d.UnmountVolume(r.Name)" like in Unmount?
There was a problem hiding this comment.
Logically we do not want to unmount since we know the mount has failed. We just want to clean up the attach.
Technically UnmountVolume does a set of useless calls (i.e. tries to locate the name and unmount volume) which we know will fail and guarantee confusing messages about failing to unmount, and then it will do the only useful step (d.ops.Detach) which we can do directly.
I guess that was a long winded version of "no. we need to call Detach" :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we detach after fresh volume mount failure (before returning failure to Docker)
Mount()used to drop the refcount and immediately return failure to upstairs - without detaching.Fix some warning to print correctly
Testing
Manual:
Failed to load config file /etc/docker-volume-vsphere.conf. (it used to beFailed to load config file %s /etc/docker-volume-vsphere.confDetaching vol2 - it is not used anymoremessage and VMDK is detached from the VM