This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Support for building DVS as Docker Managed Plugin. #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker managed plugins are currently documented [here](https://docs.docker.com/engine/extend/) This PR introduces new folder `./plugin`. Running `make all` in this folder will assume that the DVS is pre-built and dockerhub is authenticared with (`docker login`), then it will package DVS as a Managed Plugin, and push to dockerhub. See Makefile for name/tag and location. Assuming the Makefile defines names as 'cnastorage/docker-volume-vsphere:0.12', this plugin then could be installed on Docker (1.13+) as follows: * no question asked, and pretend the plugin name is 'vsphere' (can be used in `volume create` and `plugin rm` ``` docker plugin install --grant-all-permissions --alias vsphere cnastorage/docker-volume-vsphere:0.12 ``` * vanilla interactive install as disabled ``` docker plugin install --disable cnastorage/docker-volume-vsphere:0.12 ```
pdhamdhere
reviewed
Mar 8, 2017
plugin/Makefile
Outdated
| BINARY := docker-volume-vsphere | ||
| BIN_LOC := ../build | ||
|
|
||
| # Tmp docker image used to constuct rootfs + our banaries |
There was a problem hiding this comment.
typo banaries => binaries
plugin/config.json
Outdated
| "Documentation": "http://vmware.github.io/docker-volume-vsphere/documentation", | ||
| "Entrypoint": ["/usr/bin/docker-volume-vsphere", "--log_level", "info"], | ||
| "PropagatedMount": "/mnt/vmdk", | ||
| "Mounts": [ |
There was a problem hiding this comment.
What about "/etc/" for /etc/docker-volume-vsphere.conf
There was a problem hiding this comment.
yeah. I did not want to open up all important folders. I think I will change it to /etc/vmware/ and open /etc/vmware. Comments ?
| USER := cnastorage | ||
|
|
||
| PLUGIN_NAME=$(USER)/docker-volume-vsphere | ||
| PLUGIN_TAG=0.12 |
There was a problem hiding this comment.
Later we will have to find a way to separate dev builds from release tags.
msterin
force-pushed
the
managed_plugin.msterin
branch
from
d7d699b
to
a71346e
Compare
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #886
Docker managed plugins are currently documented here
This PR introduces new folder
./plugin. Runningmake allin this folder will assume thatthe DVS is pre-built and dockerhub is authenticared with
docker login, then it will package DVSas a Managed Plugin, and push to dockerhub.
Note that this is not integrated with Build or CI - since we do Build under Docker, a bit more work is needed in central Makefile and drone script - I will do it in a separate PR if this one will be approved/merged soon, or in an extension to this one if it will still be in review.
See Makefile for name/tag and location.
Assuming the Makefile defines names as 'cnastorage/docker-volume-vsphere:0.12', the plugin could
be installed on Docker (1.13+) as follows:
volume createandplugin rm)docker plugin enableto be operationalThe
docker volumecommand behaves as before but the plugin name indocker createis either what was passed as--aliasor the full plugin name , i.e.cnastorage/docker-volume-vsphere:0.12