This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Allow setting log level from docker plugin install
#1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaominchen
approved these changes
Mar 9, 2017
| @@ -48,6 +47,13 @@ | |||
| "Capabilities": ["CAP_SYS_ADMIN"], | |||
| "Devices": null | |||
|
|
|||
| }, | |||
| "Env": [ { | |||
| "name": "DVV_LOG_LEVEL", | |||
There was a problem hiding this comment.
How about just "LOG_LEVEL"?
There was a problem hiding this comment.
since it's an env vars, we need to allow different log levels for different components and LOG_LEVEL is too generic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting log level of managed plugin to debug (or other level).
This is done by adding
DVV_LOG_LEVEL=debug(or other level) to the end ofdocker plugin install...command.tested: installed with and without the option and checked the log shows correct level .
doc: plugin/Readme.md