Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

make TestVolumeCreationFirstTime data driven to run against both vms on we use on CI #1018

Conversation

shuklanirdesh82
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 commented Mar 10, 2017

fixes #1017 ( https://ci.vmware.run/vmware/docker-volume-vsphere/1590)

Adding support to run against both vms we use for testing.

Local run output:

=> Running target e2e-test Thu Mar 9 17:36:05 PST 2017

../misc/scripts/build.sh e2e-dkrVolDriver-test "10.20.105.97" "10.20.105.102" "10.20.104.59"
make: Entering directory `/go/src/github.com/vmware/docker-volume-vsphere/vmdk_plugin'

=> Running target e2e-dkrVolDriver-test Fri Mar 10 01:36:06 UTC 2017

GO15VENDOREXPERIMENT=1 go test github.com/vmware/docker-volume-vsphere/vmdk_plugin/E2E_Tests -cover -v
=== RUN   TestVolumeCreationFirstTime

creating volume [abc_1489109767] on VM[10.20.105.102]
destroying volume [abc_1489109767]
creating volume [abc_1489109774] on VM[10.20.104.59]
destroying volume [abc_1489109774]--- PASS: TestVolumeCreationFirstTime (15.43s)
	createVolume_test.go:63: 
		Testcase passed: successfully able to create volume [abc_1489109767
		]
	createVolume_test.go:63: 
		Testcase passed: successfully able to create volume [abc_1489109774
		]

//CC @govint

@pshahzeb
Copy link
Contributor

Just confirming about running it against photon VM since #1017 description talks about failing against photon VMs

Copy link
Contributor

@pshahzeb pshahzeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msterin
Copy link
Contributor

msterin commented Mar 11, 2017

There is nothing in the change about specifically "ubunbtu" VM. It looks like the change content is

Run the test against both of the test VMs we use now.  

Since the 2 vms we use are Photon and Ubuntu, this change 
will make sure we test vs both distros, not Photon only  (as now) 

is it right ? Can you please fix the commit message and PR ?

Other than that, LGTM

@shuklanirdesh82
Copy link
Contributor Author

#1018 (comment)
@pshahzeb the idea behind this PR was to run against ubuntu vm as well.

@shuklanirdesh82
Copy link
Contributor Author

#1018 (comment)

@msterin Thanks Mark for the suggestion! totally makes sense and more intuitive. I will update the commit message before submitting the PR.

Since the 2 vms we use are Photon and Ubuntu, this change
will make sure we test vs both distros, not Photon only  (as now)
@shuklanirdesh82 shuklanirdesh82 force-pushed the addingIterationForE2Etest.shuklanirdesh82 branch from e566e9a to 6e8866e Compare March 11, 2017 00:33
@shuklanirdesh82 shuklanirdesh82 changed the title make data driven to run TestVolumeCreationFirstTime against ubuntu vm on CI make TestVolumeCreationFirstTime data driven to run against both vms on we use on CI Mar 11, 2017
@shuklanirdesh82 shuklanirdesh82 merged commit 4d7c978 into vmware-archive:master Mar 11, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the addingIterationForE2Etest.shuklanirdesh82 branch March 11, 2017 00:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run the test against both of the test VMs we use now
4 participants