This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Added Makefile flexibility to use in CI and dev builds #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuklanirdesh82
approved these changes
Mar 10, 2017
plugin/Makefile
Outdated
| # use EXTRA_TAG for adding suffixes like "-CI" or "-RELEASE" (otional) | ||
| PLUGIN_TAG ?= $(GIT_TAG)$(EXTRA_TAG) | ||
|
|
||
| # plugin name - used as a base for ful plugin name and container for extracting rootfs |
There was a problem hiding this comment.
nit: "full" ... I guess
plugin/Makefile
Outdated
| docker plugin push $(PLUGIN_NAME):$(PLUGIN_TAG) | ||
| @echo Pushing $(PLUGIN_NAME):$(PLUGIN_TAG) to dockerhub.io... | ||
| @docker plugin push $(PLUGIN_NAME):$(PLUGIN_TAG) || \ | ||
| echo 'Please make sure the plugin is build ("make clean plugin") and you have logged in to docker hub first ("docker login -u $(DOCKER_HUB_USER)")' |
There was a problem hiding this comment.
how about following message?
the plugin is build => the plugin is built
There was a problem hiding this comment.
thanks, both typos fixed
|
CI failing on the known issue Merging |
msterin
force-pushed
the
managed_plugin_ci.msterin
branch
from
d64cf05
to
218a6b7
Compare
shaominchen
reviewed
Mar 11, 2017
|
|
||
|
|
||
| push: | ||
| docker plugin push $(PLUGIN_NAME):$(PLUGIN_TAG) | ||
| @echo Pushing $(PLUGIN_NAME):$(PLUGIN_TAG) to dockerhub.io... |
There was a problem hiding this comment.
Nit: remove one redundant space
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #886
tested: manual runs and demo to @shuklanirdesh82 :-)
NOTE: Managed plugin are out of "experimental" in Docker 1.13, so it works on 1.13 or new versioning scheme (Docker '17.xx...')
//CC @shuklanirdesh82