Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

[Trivial] Correcting vmdkops_admin -c option #1025

Merged
merged 1 commit into from
Mar 13, 2017
Merged

[Trivial] Correcting vmdkops_admin -c option #1025

merged 1 commit into from
Mar 13, 2017

Conversation

shuklanirdesh82
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 commented Mar 13, 2017 •
edited

fixes #1024

re-ordering the column messed up ls -c output.

[root@promc-2n-dhcp105-97:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py ls -c capacity
Policy  
------  
N/A     
N/A

Testing done: locally

With fix:

[root@promc-2n-dhcp105-97:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py ls -c capacity
Capacity  
--------  
1GB       
1GB       
1GB       
1GB

@shuklanirdesh82 shuklanirdesh82 added this to the 0.13 milestone Mar 13, 2017
@shuklanirdesh82 shuklanirdesh82 self-assigned this Mar 13, 2017
shaominchen
shaominchen approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@shaominchen shaominchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lipingxue
lipingxue approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuklanirdesh82 shuklanirdesh82 merged commit f07d43b into vmware-archive:master Mar 13, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the fixRegressionTenantColAddition.shuklanirdesh82 branch March 13, 2017 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lipingxue lipingxue lipingxue approved these changes

@shaominchen shaominchen shaominchen approved these changes

Assignees

@shuklanirdesh82 shuklanirdesh82

Labels
cla-not-required component/adminCli
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

Regression in admin_cli with choices
4 participants
@shuklanirdesh82 @lipingxue @shaominchen @vmwclabot