Setting LANG environment variable for proper encoding #1029

pshahzeb · 2017-03-13T23:12:38Z

Currently, the vmdk_ops service is invoked through watchdog.sh on esx host.
It unsets the environment variables to avoid file mapping. See /sbin/watchdog.sh Line:45
Setting it to ensure proper encoding especially in cases where string contents include unicode characters

Following output when the volume name as well as datastore name have unicode characters

root@photon-xVmYMbyTn [ ~ ]# docker volume create --driver=vsphere --name=special_name_你你
special_name_你你
root@photon-xVmYMbyTn [ ~ ]# docker volume ls
DRIVER              VOLUME NAME
vsphere             special_name_你你@sharedVmfs-你你

Fixes #575

Currently, the vmdk_ops service is invoked through watchdog.sh on esx host. It unsets the environment variables to avoid file mapping. See /sbin/watchdog.sh Line:45 Setting it to ensure proper encoding especially in cases where string contents include unicode characters Fixes #575

shaominchen

LGTM.

vmwclabot added the cla-not-required label Mar 13, 2017

pdhamdhere approved these changes Mar 13, 2017

View reviewed changes

shaominchen approved these changes Mar 13, 2017

View reviewed changes

msterin approved these changes Mar 14, 2017

View reviewed changes

msterin merged commit 6e97b8a into master Mar 14, 2017

msterin deleted the issue_575 branch March 14, 2017 18:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting LANG environment variable for proper encoding #1029

Setting LANG environment variable for proper encoding #1029

pshahzeb commented Mar 13, 2017

shaominchen left a comment

Setting LANG environment variable for proper encoding #1029

Setting LANG environment variable for proper encoding #1029

Conversation

pshahzeb commented Mar 13, 2017

shaominchen left a comment

Choose a reason for hiding this comment