This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Documentation update for admin policy rm and docker volume inspect commands #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshahzeb
changed the title
pshahzeb
changed the title
| @@ -127,6 +127,7 @@ docker volume inspect MyVolume | |||
| } | |||
| ] | |||
| ``` | |||
| Note: For disk formats zeroedthick and zeroedthick, the allocated size would be total size plus the size of replicas. | |||
There was a problem hiding this comment.
don't we need to add this at known issue?
There was a problem hiding this comment.
IMO, it is not an issue. The disk format's nature results in this behavior.
shuklanirdesh82
approved these changes
Mar 13, 2017
There was a problem hiding this comment.
Please check with @msterin or @pdhamdhere for adding the Note into known issue part or not.
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of --name option instead of positional name for admin policy rm command
Note for docker volume inspect command in case of zeroedthick and eagerzeroedthick disk formats. It shows allocated size to be total size plus the size of replicas
Fixes #922 #961