Moved admin 'ls' and 'set' commands under 'volume'

[msterin]

Rename 'vmdkops_admin ls" to vmdkops_admin volume ls
and rename ‘vmdkops_admin set’ to vmdkops_admin volume set

This is a part of #1043

As I work through multi-ESX tenancy code, some pieces ask for fix or implementation and make it easier for me to proceed. I do not want to bundle them all in a large PR, so I am submitting individual PRs which are useful on their own. This is one of them,

Test: make test-esx locally. Manual validation. CI (in progress)

[root@localhost:~] time  /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py volume ls 
Volume   Datastore      VM-Group  Capacity  Used  Filesystem  Policy          Disk Format  Attached-to  Access      Attach-as               Created By  Created Date              
-------  -------------  --------  --------  ----  ----------  --------------  -----------  -----------  ----------  ----------------------  ----------  ------------------------  
vol      Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:54:43 2016  
vol1     Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:54:57 2016  
Volume1  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:56:16 2016  
Volume2  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:56:19 2016  
Volume3  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:56:22 2016  
Volume4  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:58:08 2016  
Volume5  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:58:12 2016  
Volume6  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:58:14 2016  
Volume7  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:58:37 2016  
Volume8  Datastore2     _DEFAULT  100MB     13MB  ext4        N/A             thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:59:51 2016  
vo2      vsanDatastore  _DEFAULT  100MB     40MB  ext4        [VSAN default]  thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:52:51 2016  
vol      vsanDatastore  _DEFAULT  100MB     40MB  ext4        [VSAN default]  thin         detached     read-write  independent_persistent  umini-1     Fri Nov  4 02:53:05 2016  

real	0m 1.61s
user	0m 0.96s
sys	0m 0.00s

//CC @pshahzeb @lipingxue

[lipingxue]

The comments in L109-L122 still use "vmdkops_admin.py tenant...", which need to be replaced with "vmdkops_admin.py vm-group" since we have renamed "vmdkops_admin.py tenant" command to "vmdk_ops_admin.py vm-group".

In L122, the subcommand for "vmdkops_admin.py vm-group" are create, update, rm, ls , vm , access. So L122 should be change to something like this:

usage: vmdkops_admin.py vm-group [-h] {create, update, rm, ls, vm, access} ...

[msterin]

@lipingxue - cleaning up 'tenant->vm-group' terminology conversion is out of scope for this PR. The PR is targeting 'ls' and 'set' commands conversion to 'volume ls' and 'volume set'.

I just fixed a couple of locations I noticed with old "tenant" in messages. for common good. If you feel it should not be there I will be happy to rollback these, but I do not plan to put tenant-related cleanup here.

Besides , the lines you've referred to is the data structure explanation for arg parse support, it is not documentation for the actual usage.

Please do comment/suggest on the 'ls' and 'set' commands conversion to 'volume ls' and 'volume set'.

[pshahzeb]

LGTM

[pdhamdhere]

@msterin can you do dummy push to restart CI CC/ @shuklanirdesh82

[shuklanirdesh82]

@pdhamdhere's comment #1055 (comment)

let me restart this specific run. (https://ci.vmware.run/vmware/docker-volume-vsphere/1731)

[lipingxue]

LGTM

[msterin]

tests passed but the last (concurrent) timed out. Since this PR impacts only admin CLI, merging.