Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Disabling concurrency test on same host #1066

Merged
merged 1 commit into from
Mar 23, 2017
Merged

Conversation

pdhamdhere
Copy link
Contributor

Test will be re-enabled once we root cause & fix #1062

Test will be re-enabled once we root cause & fix #1062
Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me .. depends on the CI run.

@govint
Copy link
Contributor

govint commented Mar 23, 2017

Suggest leaving this in, at least see if we get a repro. If we still want to turn it off then can we leave the two instance paralllel test and clone test in place. And comment only the "same-host" test commented. With Go 1.7 is the issue still seen?

@pdhamdhere
Copy link
Contributor Author

@govint

With Go 1.7 is the issue still seen?

Yes, See CI run failed with same error.

@pdhamdhere pdhamdhere merged commit dadf7db into master Mar 23, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the pdhamdhere-disable-test branch March 23, 2017 23:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin panic during format-remove
5 participants