Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Update README.md #1115

Merged
merged 1 commit into from
Mar 31, 2017
Merged

Conversation

shuklanirdesh82
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 commented Mar 30, 2017

  • Adding information for leveraging vDVS as managed plugin
  • Adding new published blog entry
  • Removing information for deb/rpms (stop generating builds from 0.13 release)
  • Additional cosmetic changes to existing readme text

Fixes one of the action item #1051

/cc @tusharnt @vmware/cna_storage-maintainers

README.md Outdated
[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
[Docker recommends that the docker engine should start after the plugins.](https://docs.docker.com/engine/extend/plugin_api/)

Starting 0.13 release, no more DEB/RPMs as vDVS(vSphere docker volume service) is available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description)! It requires to have docker 1.13/17.03 and above.
Copy link
Contributor

@govint govint Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could reword as
"Starting 0.13 release, DEB/RPMs are deprecated going forward and will not be available, with the vDVS(vSphere docker volume service) being available on Docker store! The service requires to have docker 1.13/17.03 or later installed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be located later in a separate section, indicating the DEB/RPM packages are deprecated henceforth.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker version has already been mentioned above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

README.md Outdated
@@ -54,11 +62,14 @@ The Docker volume plugin requires the docker engine to be installed as a prerequ
Ubuntu users to configure the docker repository and pull the `docker-engine` package from there.
Ubuntu users can find instructions [here](https://docs.docker.com/engine/installation/linux/ubuntulinux/).

[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
[Docker recommends that the docker engine should start after the plugins.](https://docs.docker.com/engine/extend/plugin_api/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems out of place here, can it be moved to a Q/A section below or an FAQ below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just spacing/formatting fix.

Ok, removing this.

README.md Outdated

```
sudo dpkg -i <name>.deb # Ubuntu or deb based distros
sudo rpm -ivh <name>.rpm # Photon or rpm based distros
docker plugin install --grant-all-permissions --alias vsphere store/vmware/docker-volume-vsphere:0.12
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest keeping all plugin installation discussion and steps in one section and ensure no duplication of the same details.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

README.md Outdated
1. ESX: The ESX code is packaged as [a vib or an offline depot](http://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.vsphere.install.doc/GUID-29491174-238E-4708-A78F-8FE95156D6A3.html#GUID-29491174-238E-4708-A78F-8FE95156D6A3)
2. VM Running Docker: Plugin is available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description).

The plugin could be installed on Docker (1.13+) as follows:
Copy link
Contributor

@govint govint Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make this line and the below steps all under an "Installation" section. And docker version should be the current naming scheme, so 1.13/17.x or later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's correct! removing from here and will be making sure no repetition.

README.md Outdated
@@ -139,10 +135,10 @@ VMware ESXi:
- 6.0 u2
- 6.5

Docker: 1.9 and higher
Docker: 1.9 and higher (Recommended 1.13/17.03 and above to use managed plugin)

Copy link
Contributor

@govint govint Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be like, "Docker versions earlier than 1.13 aren't supported any more as the vDVS is only supported as a managed plugin (Docker versions 1.13/17.03 and later).

Without pkgs, the versions earlier than 1.13 can't be supported.

README.md Outdated

Guest Operating System:
- [Photon 1.0] (https://vmware.github.io/photon/) (Includes open-vm-tools)
- [Photon 1.0](https://vmware.github.io/photon/) (Includes open-vm-tools)
Copy link
Contributor

@govint govint Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls. include Photon OS version to avoid the vsocket issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Contributor

@govint govint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments on re-wording and placing description in separate sections.

Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
vSphere Docker Volume Service enables customers to address persistent storage requirements for Docker containers in vSphere environments. This service is integrated with [Docker Volume Plugin framework](https://docs.docker.com/engine/extend/plugins_volume/). Docker users can now consume vSphere Storage (vSAN, VMFS, NFS) to stateful containers using Docker.
vSphere Docker Volume Service (vDVS) enables customers to address persistent storage requirements for Docker containers in vSphere environments. This service is integrated with [Docker Volume Plugin framework](https://docs.docker.com/engine/extend/plugins_volume/). Docker users can now consume vSphere Storage (vSAN, VMFS, NFS) to stateful containers using Docker.

vDVS is now Docker certified and available on the [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description). More information is found at [VMware's official blog](https://blogs.vmware.com/virtualblocks/2017/03/29/vsphere-docker-volume-service-now-docker-certified/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md should not point to blog but rather point to documentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

README.md Outdated
@@ -15,14 +17,20 @@ Detailed documentation can be found in our [GitHub Documenation Page](http://vmw

## Download

**[Click here to download (Github releases)] (https://github.com/vmware/docker-volume-vsphere/releases)**
**Click here to download [Github releases](https://github.com/vmware/docker-volume-vsphere/releases)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Original was fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

original => [Click here to download (Github releases)] (https://github.com/vmware/docker-volume-vsphere/releases)
with this change => Click here to download Github releases

Just a formatting change, please let me what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Original was broken with nested parenthesis. Fine with me.

README.md Outdated
@@ -15,14 +17,20 @@ Detailed documentation can be found in our [GitHub Documenation Page](http://vmw

## Download

**[Click here to download (Github releases)] (https://github.com/vmware/docker-volume-vsphere/releases)**
**Click here to download [Github releases](https://github.com/vmware/docker-volume-vsphere/releases)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we going to publish to bintray?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github release page still shows the change log and release note. Deliverable will be removed and bintray link for VIB download will be provided from Github release page.

what do you suggest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

README.md Outdated
1. ESX: The ESX code is packaged as [a vib or an offline depot](http://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.vsphere.install.doc/GUID-29491174-238E-4708-A78F-8FE95156D6A3.html#GUID-29491174-238E-4708-A78F-8FE95156D6A3)
2. VM Running Docker: Plugin is available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description).

The plugin could be installed on Docker (1.13+) as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should retain RPM/Deb in this release. There should be overlap for at least one release.

Download section should not have Install instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
@@ -54,11 +62,14 @@ The Docker volume plugin requires the docker engine to be installed as a prerequ
Ubuntu users to configure the docker repository and pull the `docker-engine` package from there.
Ubuntu users can find instructions [here](https://docs.docker.com/engine/installation/linux/ubuntulinux/).

[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
[Docker recommends that the docker engine should start after the plugins.](https://docs.docker.com/engine/extend/plugin_api/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please remove this.

README.md Outdated
[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
[Docker recommends that the docker engine should start after the plugins.](https://docs.docker.com/engine/extend/plugin_api/)

Starting 0.13 release, no more DEB/RPMs as vDVS(vSphere docker volume service) is available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description)! It requires to have docker 1.13/17.03 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep RPM/Deb in this release. You can add a note that DEB/RPMs are deprecated going forward and will not be available

For Docker 1.13/17.x, install vDVS managed plugin as follows;
docker plugin install --grant-all-permissions --alias vsphere store/vmware/docker-volume-vsphere:<release>

Remove "no question asked and pretend the plugin name is 'vsphere' "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
@@ -159,7 +153,7 @@ Guest Operating System:

### Public
* [containers@vmware.com](cna-storage <containers@vmware.com>)
Copy link
Contributor

@tusharnt tusharnt Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be changed to : containers@vmware.com. Please remove cna-storage.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description is also pointing to the same email id.

BTW, I haven't touched that line; not sure if it is showing into the diff

Copy link
Contributor

@pdhamdhere pdhamdhere Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
vSphere Docker Volume Service enables customers to address persistent storage requirements for Docker containers in vSphere environments. This service is integrated with [Docker Volume Plugin framework](https://docs.docker.com/engine/extend/plugins_volume/). Docker users can now consume vSphere Storage (vSAN, VMFS, NFS) to stateful containers using Docker.
vSphere Docker Volume Service (vDVS) enables customers to address persistent storage requirements for Docker containers in vSphere environments. This service is integrated with [Docker Volume Plugin framework](https://docs.docker.com/engine/extend/plugins_volume/). Docker users can now consume vSphere Storage (vSAN, VMFS, NFS) to stateful containers using Docker.

vDVS is now Docker certified and available on the [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description). More information is found at [VMware's official blog](https://blogs.vmware.com/virtualblocks/2017/03/29/vsphere-docker-volume-service-now-docker-certified/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change it to comply with publisher agreement;

vDVS is Docker Certified to use with Docker Enterprise Edition and available in Docker store.

Display "Docker Certified" logo somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Please have look at the latest diff.

README.md Outdated
@@ -1,8 +1,12 @@
[![Build Status](https://ci.vmware.run/api/badges/vmware/docker-volume-vsphere/status.svg)](https://ci.vmware.run/vmware/docker-volume-vsphere) [![Join the chat at https://gitter.im/vmware/docker-volume-vsphere](https://badges.gitter.im/vmware/docker-volume-vsphere.svg)](https://gitter.im/vmware/docker-volume-vsphere?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)

[<img src="https://github.com/vmware/docker-volume-vsphere/blob/docUpdateManagedPlugin.shuklanirdesh82/docs/misc/Docker%20Certified.png" width="96">](https://store.docker.com/plugins/vsphere-docker-volume-service?tab=description)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be added as badge?

Link is pointing to private branch. It should point to master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image is uploaded and checked into master; reference has been corrected.

README.md Outdated
# vSphere Docker Volume Service

vSphere Docker Volume Service enables customers to address persistent storage requirements for Docker containers in vSphere environments. This service is integrated with [Docker Volume Plugin framework](https://docs.docker.com/engine/extend/plugins_volume/). Docker users can now consume vSphere Storage (vSAN, VMFS, NFS) to stateful containers using Docker.
vSphere Docker Volume Service (vDVS) enables customers to address persistent storage requirements for Docker containers in vSphere environments. This service is integrated with [Docker Volume Plugin framework](https://docs.docker.com/engine/extend/plugins_volume/). Docker users can now consume vSphere Storage (vSAN, VMFS, NFS) to stateful containers using Docker.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
@@ -15,14 +19,20 @@ Detailed documentation can be found in our [GitHub Documenation Page](http://vmw

## Download

**[Click here to download (Github releases)] (https://github.com/vmware/docker-volume-vsphere/releases)**
**Click here to download from [Github releases](https://github.com/vmware/docker-volume-vsphere/releases)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
@@ -54,12 +56,13 @@ The Docker volume plugin requires the docker engine to be installed as a prerequ
Ubuntu users to configure the docker repository and pull the `docker-engine` package from there.
Ubuntu users can find instructions [here](https://docs.docker.com/engine/installation/linux/ubuntulinux/).

[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
Starting 0.13 release, DEB/RPMs are deprecated going forward and will not be available, with the vDVS(vSphere docker volume service) being available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description)! It requires to have docker 1.13/17.03 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Docker Host (VM)

For Docker 1.13 and above, install the plugin from Docker Store.

docker plugin install --grant-all-permissions --alias vsphere store/vmware/docker-volume-vsphere:0.13

DEB/RPM packages will be deprecated going forward and will not be available.

-sudo dpkg -i <name>.deb # Ubuntu or deb based distros
-sudo rpm -ivh <name>.rpm # Photon or rpm based distros

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
@@ -139,10 +127,10 @@ VMware ESXi:
- 6.0 u2
- 6.5

Docker: 1.9 and higher
Docker: 1.9 and higher (Recommended 1.13/17.03 and above to use managed plugin)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to Docker 1.12 and higher

Also move this line at the end of GOS section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
@@ -139,10 +127,10 @@ VMware ESXi:
- 6.0 u2
- 6.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just put them as;

VMware ESXi:

  • 6.0, 6.0u1, 6.0u2
  • 6.5

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

VMware ESXi: 6.0 and above

README.md Outdated

Guest Operating System:
- [Photon 1.0] (https://vmware.github.io/photon/) (Includes open-vm-tools)
- [Photon 1.0, Revision 2](https://github.com/vmware/photon/wiki/Downloading-Photon-OS#photon-os-10-revision-2-binaries) (v4.4.51 or later)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put Photon at the bottom of list :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

README.md Outdated
@@ -159,7 +153,7 @@ Guest Operating System:

### Public
* [containers@vmware.com](cna-storage <containers@vmware.com>)
Copy link
Contributor

@pdhamdhere pdhamdhere Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
@@ -159,7 +147,7 @@ Guest Operating System:

### Public
* [containers@vmware.com](cna-storage <containers@vmware.com>)
* [Issues] (https://github.com/vmware/docker-volume-vsphere/issues)
* [Issues](https://github.com/vmware/docker-volume-vsphere/issues)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are there, can you update " # Known Issues". All of them are already fixed. May be add following-

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@shuklanirdesh82 shuklanirdesh82 force-pushed the docUpdateManagedPlugin.shuklanirdesh82 branch 4 times, most recently from debd4ae to 90baed2 Compare March 30, 2017 19:02
README.md Outdated
* Photon/RedHat => Download RPM
* Ubuntu => Download Deb.
1. ESX: The ESX code is packaged as [a vib or an offline depot](http://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.vsphere.install.doc/GUID-29491174-238E-4708-A78F-8FE95156D6A3.html#GUID-29491174-238E-4708-A78F-8FE95156D6A3)
2. VM Running Docker: Plugin is available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description).

Pick the latest release and use the same version of ESX and VM release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick the latest release and use the same version of ESX and VM release. -> Please use VIB and managed plugin corresponding to the same release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

README.md Outdated
2. VM Running Docker: The docker service is packaged as a deb or rpm file.
* Photon/RedHat => Download RPM
* Ubuntu => Download Deb.
1. ESX: The ESX code is packaged as [a vib or an offline depot](http://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.vsphere.install.doc/GUID-29491174-238E-4708-A78F-8FE95156D6A3.html#GUID-29491174-238E-4708-A78F-8FE95156D6A3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESX -> VIB

README.md Outdated
* Photon/RedHat => Download RPM
* Ubuntu => Download Deb.
1. ESX: The ESX code is packaged as [a vib or an offline depot](http://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.vsphere.install.doc/GUID-29491174-238E-4708-A78F-8FE95156D6A3.html#GUID-29491174-238E-4708-A78F-8FE95156D6A3)
2. VM Running Docker: Plugin is available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VM running docker -> Managed plugin

@@ -134,19 +122,17 @@ logging config format for content details.
## Tested on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewording suggestion : Tested on -> Supported configuration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, let's keep it tested until GA.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah discussed with @tusharnt offline to drop the comment.

README.md Outdated
@@ -54,12 +56,13 @@ The Docker volume plugin requires the docker engine to be installed as a prerequ
Ubuntu users to configure the docker repository and pull the `docker-engine` package from there.
Ubuntu users can find instructions [here](https://docs.docker.com/engine/installation/linux/ubuntulinux/).

[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
Starting 0.13 release, DEB/RPMs are deprecated going forward and will not be available, with the vDVS(vSphere docker volume service) being available on [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description)! It requires to have docker 1.13/17.03 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Starting 0.13 release, DEB/RPMs are deprecated going forward and will not be available, with the vDVS(vSphere docker volume service) being available on Docker store! -> Please note that DEB/RPMs will be deprecated starting 0.13 release. Instead please use managed plugin from Docker store!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

@shuklanirdesh82 shuklanirdesh82 force-pushed the docUpdateManagedPlugin.shuklanirdesh82 branch 3 times, most recently from dcb5959 to d5764e0 Compare March 30, 2017 22:27
Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

README.md Outdated
@@ -54,11 +54,19 @@ The Docker volume plugin requires the docker engine to be installed as a prerequ
Ubuntu users to configure the docker repository and pull the `docker-engine` package from there.
Ubuntu users can find instructions [here](https://docs.docker.com/engine/installation/linux/ubuntulinux/).

[Docker recommends that the docker engine should start after the plugins.] (https://docs.docker.com/engine/extend/plugin_api/)
**Note:** DEB/RPMs will be deprecated starting vDVS 0.13 release instead please use managed plugin from [Docker store](https://store.docker.com/plugins/e15dc9d5-e20e-4fb8-8876-9615e6e6e852?tab=description)! It requires to have Docker 1.13/17.03 and above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace entire "### On Docker Host (VM)" section with following;

On Docker Host (VM)

For Docker 1.13 and above, install managed plugin from Docker Store.

docker plugin install --grant-all-permissions --alias vsphere store/vmware/docker-volume-vsphere:latest

For Docker 1.12 and earlier, use DEB or RPM package.

-sudo dpkg -i <name>.deb # Ubuntu or deb based distros
-sudo rpm -ivh <name>.rpm # Photon or rpm based distros

Note: DEB/RPM packages will be deprecated going forward and will not be available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
* **Turning on debug logging**: stop the service and manually run with ``--log_level=debug` flag
* **Turning on debug logging**: You can change the log level by passing `VDVS_LOG_LEVEL` key to `docker plugin install`, e.g.
```
docker plugin install --grant-all-permissions --alias vsphere store/vmware/docker-volume-vsphere:0.12 VDVS_LOG_LEVEL=debug
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.12 => latest

@shuklanirdesh82 shuklanirdesh82 force-pushed the docUpdateManagedPlugin.shuklanirdesh82 branch from d5764e0 to 351587a Compare March 30, 2017 23:48
- Adding information for leveraging vDVS as managed plugin
- Adding new published blog entry
- Additional cosmetic changes to existing readme text
@shuklanirdesh82 shuklanirdesh82 force-pushed the docUpdateManagedPlugin.shuklanirdesh82 branch from 351587a to 171e5a8 Compare March 31, 2017 00:59
Copy link
Contributor

@tusharnt tusharnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuklanirdesh82 shuklanirdesh82 merged commit 4493235 into master Mar 31, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the docUpdateManagedPlugin.shuklanirdesh82 branch March 31, 2017 02:14
@shuklanirdesh82
Copy link
Contributor Author

@govint Thanks for your comments, I have addressed all your supplied comment. Please have a look and share your comment if there is any.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants