This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Modified Makefile so plugin build under HGFS #1182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuklanirdesh82
approved these changes
Apr 20, 2017
plugin/Makefile
Outdated
| docker plugin create $(PLUGIN_NAME):$(PLUGIN_TAG) . | ||
|
|
||
| docker plugin create $(PLUGIN_NAME):$(PLUGIN_TAG) $(TMP_LOC) | ||
| @rm -rf $(TMP_LOC) |
There was a problem hiding this comment.
nit: L89 takes care this .. can it be redundant and removed? Please explain if I am missing something here.
There was a problem hiding this comment.
yes, it's a missed leftover. Will remove. Thanks !
msterin
force-pushed
the
build_hgfs.msterin
branch
5 times, most recently
from
6af12f1
to
910abcc
Compare
When the repo is checked out under VMWare own HGFS on a guest (Linux) , and the Host is WIndows, the plugin build fails because HGFS in this combination does not support symlinks and 'docker plugin export` command uses it. This PR moves the actual plugin files manipulation under /tmp so the build succeeds for anyone who (like myself) runs linux guest in VMWare Workstation on WIndows , and shares repo dir over HGFS
msterin
force-pushed
the
build_hgfs.msterin
branch
from
910abcc
to
8fe6d2e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the repo is checked out under VMWare own HGFS on a guest (Linux) , and the Host is WIndows,
the plugin build fails because HGFS in this combination does not support symlinks
and 'docker plugin export` command uses it.
This PR moves the actual plugin files manipulation under /tmp so the build succeeds for anyone who
(like myself) runs linux guest in VMWare Workstation on WIndows , and shares repo dir over HGFS
A side effect of this PR is that ./plugin folder is not polluted with build-only managed plugin files