Fix an issue in db connect function #1211
Conversation
|
Note: I'm still waiting for my new testbed to be ready to verify the fix. |
|
LGTM pending usual stuff: |
|
@shaominchen Please rebase your branch with master to get .drone.sec changes. |
shaominchen
force-pushed
the
issue_1144.shchen
branch
from
a28f76b
to
d02d00f
Compare
|
|
||
| try: | ||
| self.conn = sqlite3.connect(self.db_path) | ||
| except sqlite3.Error as e: |
There was a problem hiding this comment.
nit: we can log the content of object e as well.
There was a problem hiding this comment.
Sure, will log the error.
There was a problem hiding this comment.
Proposed changes looks good to me.
Can you please paste the error message (by executing the step mentioned the issue #1144) for the reference?
|
Not this PR; but I feel all the errors reported to user/admin shouldn't be marked as "internal error". They should be clear as to what error or type of error is. |
sqlite3.connect() function will throw an exception instead of returning none if running into any errors. So we should try/catch the error instead of checking for none result.
Fix #1144
Test result:
Error from step 3:
[root@sc-rdops-vm09-dhcp-28-64:/var/log/vmware] vmdkops_admin vmgroup ls
Internal Error(DB connection error at /etc/vmware/vmdkops/auth-db)
Error from vmdk_ops.log:
05/03/17 00:15:41 91741 [MainThread] [ERROR ] Failed to connect to DB (/etc/vmware/vmdkops/auth-db): unable to open database file