Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Adding trivial fix for access update testcase #1435

Conversation

shuklanirdesh82
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 commented Jun 17, 2017

reverting the logging change added to reproduce #1371 and addition to that test steps are improved too.

  1. Adding --rm flag while mounting volume so that containers is removed automatically
  2. Test code cleanup while addressing Added WIP to Readme.md #1
  3. Reverting extra logging change added as part of Add log to dump kv_str #1388

Testing done: Yes

GO15VENDOREXPERIMENT=1 go test -v -timeout 30m -tags runalways github.com/vmware/docker-volume-vsphere/tests/e2e -check.f "TestAccessUpdate"
=== RUN   Test
2017/06/17 00:34:13 Finding VM name from IP Address [10.20.104.40]
2017/06/17 00:34:14 Finding VM name from IP Address [10.20.104.40]
2017/06/17 00:34:15 Finding Datastores available on ESX
2017/06/17 00:34:15 START: VolumeAccessTestSuite.TestAccessUpdate
2017/06/17 00:34:15 Creating volume [vol_access_volume_16ddfwutxgjte@TestDatastore] on VM [10.20.104.40]
2017/06/17 00:34:16 Writing message_by_host1 to file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:21 Reading from file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:25 Writing message_by_host2 to file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:30 Reading from file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:34 Updating access to [read-only] for volume [vol_access_volume_16ddfwutxgjte@TestDatastore] 
2017/06/17 00:34:36 Writing message_by_host1 to file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:39 Writing message_by_host2 to file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:43 Updating access to [read-write] for volume [vol_access_volume_16ddfwutxgjte@TestDatastore] 
2017/06/17 00:34:45 Writing message_by_host1 to file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:50 Reading from file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:54 Writing message_by_host2 to file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:34:58 Reading from file test.txt on volume [vol_access_volume_16ddfwutxgjte@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:03 END: VolumeAccessTestSuite.TestAccessUpdate
2017/06/17 00:35:03 Destroying volume [vol_access_volume_16ddfwutxgjte@TestDatastore]
2017/06/17 00:35:05 START: VolumeAccessTestSuite.TestAccessUpdate_R_RW
2017/06/17 00:35:05 Creating volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] with options [ -o access=read-only] on VM [10.20.104.40]
2017/06/17 00:35:11 Writing message_by_host1 to file test.txt on volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:15 Writing message_by_host2 to file test.txt on volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:19 Updating access to [read-write] for volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] 
2017/06/17 00:35:21 Writing message_by_host1 to file test.txt on volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:25 Reading from file test.txt on volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:30 Writing message_by_host2 to file test.txt on volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:34 Reading from file test.txt on volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore] from VM[10.20.104.40]
2017/06/17 00:35:39 END: VolumeAccessTestSuite.TestAccessUpdate_R_RW
2017/06/17 00:35:39 Destroying volume [vol_access_volume_1l0kco5jhjsx3@TestDatastore]
OK: 2 passed
--- PASS: Test (87.86s)
PASS
ok  	github.com/vmware/docker-volume-vsphere/tests/e2e	87.861s

/CC @pdhamdhere

1. Adding --rm flag while mounting volume so that containers is removed automatically
2. Test code cleanup while addressing #1
3. Reverting extra logging change added as part of vmware-archive#1388
@shuklanirdesh82 shuklanirdesh82 force-pushed the accessUpdateTestFix.shuklanirdesh82 branch from f35817b to 69e7d7f Compare June 17, 2017 01:58
Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuklanirdesh82 shuklanirdesh82 merged commit 3652635 into vmware-archive:master Jun 17, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the accessUpdateTestFix.shuklanirdesh82 branch June 17, 2017 14:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants