This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Scripts change to enable CI for vFile. #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lipingxue
reviewed
Sep 13, 2017
| @@ -339,6 +342,11 @@ build-windows-plugin: | |||
| $(BUILD_WINDOWS_PLUGIN_SH) $(WIN_VM1) | |||
| deploy-windows-plugin: | |||
| $(DEPLOY_WINDOWS_PLUGIN_SH) "$(WIN_VMS)" | |||
| build-vfile-plugin: | |||
| $(BUILD_PLUGIN_SH) "$(VM2)" $(VFILE_PLUGIN_BIN) $(MANAGED_PLUGIN_LOC) $(SCRIPTS) $(DOCKER_HUB_REPO) $(VERSION_TAG) $(EXTRA_TAG) $(VFILE_PREFIX) | |||
There was a problem hiding this comment.
Why it is "$(VM2)"? I think it should be "$(VMS)".
There was a problem hiding this comment.
This is build, not deploy, so it only needs one VM :) see how build-plugin target works.
shuklanirdesh82
approved these changes
Sep 14, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new function name
vfilepluginfor deploy-and-test-wrapper.sh, which include the following targets:TARGET=" build-plugin build-vfile-plugin deploy-vm deploy-vfile-plugin test-e2e-runonce-vfile
This target will build both vDVS and vFile plugins and deploy them on the testbed VMs.
After that, run the tests with build tag runoncevfile.
Have tested with local testbed and is able to get 6 passed results:
Fixes: #1684