Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Show all columns in vmdkops_admin.py ls (remove -l) #430

Merged
merged 1 commit into from May 31, 2016

Conversation

andrewjstone
Copy link
Contributor

@andrewjstone andrewjstone commented May 31, 2016

Columns shown with ls -l are now the default and the -l option has been removed.
Fixed tests to reflect this and also removed the unused 'last-attached' choice
from the ls -c options.

Tested with make all and CI as well as manually via CLI on ESX.

Fixes #417

[root@localhost:~] /usr/lib/vmware/vmdkops/bin/vmdkops_admin.py ls
Volume     Datastore   Created By    Created                   Attached To  Policy  Capacity  Used
---------  ----------  ------------  ------------------------  -----------  ------  --------  -------
large-vol  datastore1  Ubuntu_15.10  Sat Apr 16 13:34:12 2016  detached     N/A     1.00GB    25.00MB
vol        datastore1  Ubuntu_15.10  Sat Apr 16 20:13:18 2016  detached     N/A     100.00MB  14.00MB
ayo        datastore1  N/A           N/A                       detached     N/A     4.00MB    2.00MB

Columns shown with ls -l are now the default and the -l option has been removed.
Fixed tests to reflect this and also removed the unused 'last-attached' choice
from the ls -c options.

Tested with make all and CI as well as manually via CLI on ESX.

Fixes #417
@msterin
Copy link
Contributor

msterin commented May 31, 2016

Nice fix. Please do add 'ls' output result to PR description.
LGMT after that.

@andrewjstone andrewjstone merged commit 45a7b65 into master May 31, 2016
@kerneltime kerneltime deleted the ls-dash-l-to-ls.ajs branch June 1, 2016 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants