Report errno and proper strings on vSocket communcation failures #435

msterin · 2016-06-02T00:28:15Z

Fixes #206

Client code passes errno up and GO code handles it.
CGO auto-returns (return_code, error) tuple and error info was there all along, we just use it now.
Server code makes sure errno is properly set (and not cleaned up by close() and the likes) ,
and sets errno when needed. Python code then generates proper messages
removed uneeded custom error codes - it turned out to be throwaway code
a few cosmetic changes - mainly dropped single letter variables since they are hard to maintain

Tested with CI and 'make all'. some error codes tested manually, to make sure the path works:

Run python service while it is already up. Log says:

05/14/16 15:19:51 562104 [ERROR  ] Failed to initialize vSocket listener: Address already in use (errno=98)
Traceback (most recent call last):
  File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 725, in main
    handleVmciRequests()
  File "/usr/lib/vmware/vmdkops/bin/vmdk_ops.py", line 667, in handleVmciRequests
    %  (os.strerror(errno), errno))
OSError: Failed to initialize vSocket listener: Address already in use (errno=98)

Run docker volume ls when the ESX service is down. Docker says

root@ubuntu-srv14:~# docker volume ls
list vmdk: VolumeDriver.List: 'list' failed: connection reset by peer (errno=104). Check that ESX service is running.
DRIVER              VOLUME NAME
root@ubuntu-srv14:~#

Fixes #206 * Client code passes errno up and GO code handles it. CGO auto0-returns (return, error) tuple and error info was there all along, we just use it now. * Server code makes sure errno is properly set (and not cleaned up by close() and the likes) , and sets errno when needed. Python code then generates proper messages * removed uneeded custom error codes - it turned out to be throwaway code * a few cosmetic changes - mainly dropped single letter variables since they are hard to maintain

andrewjstone · 2016-06-02T02:43:40Z

esx_service/vmdk_ops.py


        response = lib.vmci_reply(c, c_char_p(json.dumps(ret)))
+        errno = get_errno()


What are we doing with this errno? Should we log it?

yep, I missed this. Added check and log.
Thanks !

andrewjstone · 2016-06-02T03:06:48Z

LGTM

pdhamdhere · 2016-06-02T17:38:36Z

esx_service/vmci/vmci_client.c

@@ -175,6 +172,7 @@ vsock_get_family(void)
 }

 // Create and connect VMCI socket.
+// return success (0) or failure (-1)


nit: return CONN_SUCCESS (0) or CONN_FAILURE(-1)

kerneltime · 2016-06-02T19:54:02Z

LGTM but this code needs another round of clean up. Will see if I can get it done as part of the capabilities change.

vmwclabot added the cla-not-required label Jun 2, 2016

msterin force-pushed the vmci-errno.msterin branch from 0b3e7d9 to 36c8226 Compare June 2, 2016 00:32

andrewjstone reviewed Jun 2, 2016
View reviewed changes

pdhamdhere reviewed Jun 2, 2016
View reviewed changes

msterin force-pushed the vmci-errno.msterin branch 2 times, most recently from 8f12d41 to bfa2543 Compare June 2, 2016 19:21

Review comments addressed

bfa2543

msterin merged commit e1da74b into master Jun 2, 2016

kerneltime deleted the vmci-errno.msterin branch June 7, 2016 00:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Report errno and proper strings on vSocket communcation failures #435

Report errno and proper strings on vSocket communcation failures #435

msterin commented Jun 2, 2016 •

edited

andrewjstone Jun 2, 2016

msterin Jun 2, 2016 •

edited

andrewjstone commented Jun 2, 2016

pdhamdhere Jun 2, 2016

msterin Jun 2, 2016

kerneltime commented Jun 2, 2016


		response = lib.vmci_reply(c, c_char_p(json.dumps(ret)))
		errno = get_errno()

Report errno and proper strings on vSocket communcation failures #435

Report errno and proper strings on vSocket communcation failures #435

Conversation

msterin commented Jun 2, 2016 • edited

andrewjstone Jun 2, 2016

Choose a reason for hiding this comment

msterin Jun 2, 2016 • edited

Choose a reason for hiding this comment

andrewjstone commented Jun 2, 2016

pdhamdhere Jun 2, 2016

Choose a reason for hiding this comment

msterin Jun 2, 2016

Choose a reason for hiding this comment

kerneltime commented Jun 2, 2016

msterin commented Jun 2, 2016 •

edited

msterin Jun 2, 2016 •

edited