This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Log exceptions in ESX service #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -94,7 +94,7 @@ def vmdk_is_a_descriptor(filepath): | |||
| line = f.readline() | |||
| return line.startswith('# Disk DescriptorFile') | |||
| except: | |||
| logging.warning("Failed to open %s for descriptor check", filepath) | |||
| logging.exception("Failed to open %s for descriptor check", filepath) | |||
There was a problem hiding this comment.
Since we aren't catching a specific exception any idea what message we get in this case? Can we catch a generic exception that will get logged?
There was a problem hiding this comment.
I've added this specific one in PR description. What do you mean by catch generic exception? "except:" will cause any exception in this case rt?
import logging to vsan_policy.py log exceptions in find_child make golint happy by adding comment Log exceptions in ESX service
pdhamdhere
force-pushed
the
log-exceptions
branch
from
a66f509
to
5c488b9
Compare
|
LGTM |
| @@ -87,6 +89,7 @@ def delete(name): | |||
| try: | |||
| os.remove(policy_path(name)) | |||
| except: | |||
| logging.exception("Failed to remove %s policy file", name) | |||
There was a problem hiding this comment.
nit: not sure this one is needed , if the file does not exist silent fail is better. But it's good as is as well
There was a problem hiding this comment.
Yes, thought about it and decided to leave it there just in case for other OSErrors.
|
Thanks for taking on this ! LGTM |
|
LGTM |
|
Thanks everyone for quick review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log exceptions to make debugging easier.
Testing Done:
Manually verified exceptions in log file for e.g.