Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Change some headers for admin cli ls #457

Merged
merged 1 commit into from Jun 13, 2016

Conversation

andrewjstone
Copy link
Contributor

Attached To -> Attached To VM
Created By -> Created By VM

Tested with make all and CI

Fixes #434

Attached To -> Attached To VM
Created By -> Created By VM

Tested with make all and CI

Fixes #434
@kerneltime
Copy link
Contributor

LGTM

@pdhamdhere
Copy link
Contributor

LGTM.

@msterin
Copy link
Contributor

msterin commented Jun 11, 2016

LGTM. This one was easy :-)

P.S. It does show

Running unit tests in /tmp/vmdk_ops_unittest3288/vsan_policy_test.py...
...ERROR:root:Failed to remove test_policy policy file
Traceback (most recent call last):
  File "/tmp/vmdk_ops_unittest3288/vsan_policy.py", line 90, in delete
    os.remove(policy_path(name))
OSError: [Errno 2] No such file or directory: '/vmfs/volumes/vsan:5204bc8bc03e1c20-5a4696067b772017/dockvols/policies/test_policy

in the log - is it false positive ?

@andrewjstone
Copy link
Contributor Author

As discussed with Mark the other day, this is just a log message during a negative test, which is why CI still passes. Will work to somehow disable or annotate it.

@andrewjstone andrewjstone merged commit d2a1017 into master Jun 13, 2016
@kerneltime kerneltime deleted the admin-cli-more-descriptive-headers.ajs branch July 25, 2016 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants