This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Disk allocation format #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| format = kv.DEFAULT_ALLOCATION_FORMAT | ||
| else: | ||
| format = str(opts[kv.DISK_ALLOCATION_FORMAT]) | ||
| logging.debug("SETTING VMDK DISK ALLOCATION FORMAT to %s for %s", format, vmdk_path) |
There was a problem hiding this comment.
Don't use ALL CAPS. Use sentence case.
abrarshivani
force-pushed
the
disk-allocation-format
branch
from
b7a4ce5
to
b0fb95c
Compare
| @@ -75,7 +75,7 @@ | |||
| OBJ_TOOL_CMD = "/usr/lib/vmware/osfs/bin/objtool open -u " | |||
| OSFS_MKDIR_CMD = "/usr/lib/vmware/osfs/bin/osfs-mkdir -n " | |||
| MKFS_CMD = BIN_LOC + "/mkfs.ext4 -qF -L " | |||
| VMDK_CREATE_CMD = "/sbin/vmkfstools -d thin -c " | |||
| VMDK_CREATE_CMD = "/sbin/vmkfstools" | |||
There was a problem hiding this comment.
nit: would be better to have VMDK_CREATE_CMD = "/sbin/vmkfstools -c"
not a big deal since the string needs to be formatted anyways, just makes it more symmetric with '-U' option
|
LGTM contingent on addressing I agree with Prashant's request to add valid choices to error message. Also a couple of nits - please take a look |
abrarshivani
force-pushed
the
disk-allocation-format
branch
from
b0fb95c
to
8893a5f
Compare
| Ensure format is valid. | ||
| """ | ||
| if not format.lower() in kv.VALID_ALLOCATION_FORMATS : | ||
| raise ValidationError('Disk Allocation Format {0} does not exist. Valid options are: (thin(default), eagerzeroedthick, zeroedthick)'.format(format)) |
There was a problem hiding this comment.
I think this statement is way beyond 80char limit or whatever PEP8 recommends. You may want split & indent in 2 lines.
abrarshivani
force-pushed
the
disk-allocation-format
branch
from
8893a5f
to
d72b1dd
Compare
|
I have made changes to the code according to the comments posted here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #427
Added option for user to select disk allocation format. Example:
format choices:
"zeroedthick", "thin" (default), "eagerzeroedthick"
Tested:
make alland CI