Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Update documentation for fstype option #605

Merged
merged 3 commits into from
Sep 27, 2016
Merged

Update documentation for fstype option #605

merged 3 commits into from
Sep 27, 2016

Conversation

brunotm
Copy link
Contributor

@brunotm brunotm commented Sep 24, 2016

msterin
msterin suggested changes Sep 26, 2016
View reviewed changes
Copy link
Contributor

@msterin msterin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add info about which FS is used by default, and I will merge.

Thanks !

docs/user-guide/docker-volume-cli.md
```

Specifies which filesystem will be created on the new volume. The volume-plugin will search for a existing /sbin/mkfs.**fstype** on the docker host to create the filesystem, and if not found it will return a list of filesystems for which it has found a corresponding mkfs. The specified filesystem must be supported by the running kernel and support labels (-L flag for mkfs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add info on default ("if the flag is ommitted, ext? is used").

pdhamdhere
pdhamdhere approved these changes Sep 27, 2016
View reviewed changes
Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brunotm. LGTM!

@kerneltime
Copy link
Contributor

LGTM.
Merging this in.
@brunotm can you email us @ cna-storage@vmware.com or give us your email id ? We would like to discuss your experience so far and your use case for the plugin.

@kerneltime kerneltime merged commit 29fe5c2 into vmware-archive:master Sep 27, 2016
@kerneltime
Copy link
Contributor

The documentation will be posted to the github page along with the next release.

@kerneltime kerneltime mentioned this pull request Sep 27, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@msterin msterin msterin requested changes

@pdhamdhere pdhamdhere pdhamdhere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brunotm @kerneltime @msterin @pdhamdhere