Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Increase the range of ports tried for binding #606

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

kerneltime
Copy link
Contributor

@kerneltime kerneltime commented Sep 28, 2016

If we have more than 24 operations performed in a tight loop we
run into the issue of ports not being cleaned up and returning
an error. This change increases the range of ports that we bind.

Minor go format change that the build picked up.

Testing:

  1. Ran docker volume ls in a tight loop without issues
  2. Ran code listed in Validate client side socket port bind capability #436 without issues.

If we have more than 24 operations performed in a tight loop we
run into the issue of ports not being cleaned up and returning
an error. This change increases the range of ports that we bind.

Minor go format change that the build picked up.
@andrewjstone
Copy link
Contributor

👍

Copy link
Contributor

@pdhamdhere pdhamdhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@govint
Copy link
Contributor

govint commented Sep 29, 2016

Ship it.

I didn't do this thinking we aren't supposed to use ports from any arbitrary number less than 1023 :-). Looks good. Checked out the vmci and vsock drivers, the close() (release API in vsock driver) does release the binding rightaway. But looks like thats not even invoked when the socket is closed. REUSEADDR isn't supported at all, so no point setting it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants