Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Fix Admin Cli command to list selected columns for Filesystem Type an… #845

Merged
merged 3 commits into from Jan 9, 2017
Merged

Fix Admin Cli command to list selected columns for Filesystem Type an… #845

merged 3 commits into from Jan 9, 2017

Conversation

ashahi1
Copy link
Contributor

@ashahi1 ashahi1 commented Jan 4, 2017 •
edited by kerneltime

…d Disk Format

Fixes #844

After the change, I was able to see correct value for Disk Format and Filesystem Type.


[root@sc2-rdops-vm03-dhcp-97-99:~] usr/lib/vmware/vmdkops/bin/vmdkops_admin.py ls -c volume,datastore,disk-format,fstype
Volume  Datastore      Disk Format  Filesystem Type
------  -------------  -----------  ---------------
vol1    vsanDatastore  thin         ext4

I also ran the CI tests locally in a setup of one ESX and two VMs.

@ashahi1 ashahi1 self-assigned this Jan 4, 2017
kerneltime
kerneltime approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@kerneltime kerneltime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the commit and that will trigger the build. LGTM pending CI passing.

lipingxue
lipingxue approved these changes Jan 9, 2017
View reviewed changes
Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerneltime kerneltime merged commit 76594b4 into vmware-archive:master Jan 9, 2017
shuklanirdesh82 added a commit to shuklanirdesh82/vsphere-storage-for-docker that referenced this pull request Jan 9, 2017
@shuklanirdesh82
Supplying ssh keys and env variable to container for e2e testing
00b5fc0 
adding missing pkg and sample test file

a minor fix for CI to consume key from correct location

correcting CI faiure

reading SSH_KEY_OPT correctly

code cleanup

restarting CI run

Adding support SSH_KEY_PATH for local test run, no need to set environment vars any more

Adding target for e2e tests (addressing Ritesh's comment)

Fix Admin Cli command to list selected columns for Filesystem Type an… (vmware-archive#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format

adding new test target @test-All
shuklanirdesh82 added a commit to shuklanirdesh82/vsphere-storage-for-docker that referenced this pull request Jan 9, 2017
@shuklanirdesh82
Supplying ssh keys and env variable to container for e2e testing
38c24c2 
adding missing pkg and sample test file

a minor fix for CI to consume key from correct location

correcting CI faiure

reading SSH_KEY_OPT correctly

code cleanup

restarting CI run

Adding support SSH_KEY_PATH for local test run, no need to set environment vars any more

Adding target for e2e tests (addressing Ritesh's comment)

Fix Admin Cli command to list selected columns for Filesystem Type an… (vmware-archive#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format

adding new test target @test-All
lipingxue pushed a commit that referenced this pull request Jan 10, 2017
@ashahi1 @lipingxue
Fix Admin Cli command to list selected columns for Filesystem Type an… (
ac00c3f 
#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format
shuklanirdesh82 added a commit to shuklanirdesh82/vsphere-storage-for-docker that referenced this pull request Jan 10, 2017
@shuklanirdesh82
Supplying ssh keys and env variable to container for e2e testing
a88dcd5 
adding missing pkg and sample test file

a minor fix for CI to consume key from correct location

correcting CI faiure

reading SSH_KEY_OPT correctly

code cleanup

restarting CI run

Adding support SSH_KEY_PATH for local test run, no need to set environment vars any more

Adding target for e2e tests (addressing Ritesh's comment)

Fix Admin Cli command to list selected columns for Filesystem Type an… (vmware-archive#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format

adding new test target @test-All

adding inline comment

adding test target to drone script (Addressing Ritesh's comment)

testing out CI failure

adding e2e-test target to pick up at CI using drone script
shuklanirdesh82 added a commit that referenced this pull request Jan 10, 2017
@shuklanirdesh82
Supplying ssh keys and env variable to container for e2e testing (#851)
ac56cf3 
* Supplying ssh keys and env variable to container for e2e testing

adding missing pkg and sample test file

a minor fix for CI to consume key from correct location

correcting CI faiure

reading SSH_KEY_OPT correctly

code cleanup

restarting CI run

Adding support SSH_KEY_PATH for local test run, no need to set environment vars any more

Adding target for e2e tests (addressing Ritesh's comment)

Fix Admin Cli command to list selected columns for Filesystem Type an… (#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format

adding new test target @test-All

adding inline comment

adding test target to drone script (Addressing Ritesh's comment)

testing out CI failure

adding e2e-test target to pick up at CI using drone script

* restarting CI test
lipingxue pushed a commit that referenced this pull request Jan 10, 2017
@ashahi1 @lipingxue
Fix Admin Cli command to list selected columns for Filesystem Type an… (
f04e509 
#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format
lipingxue pushed a commit that referenced this pull request Jan 10, 2017
@shuklanirdesh82 @lipingxue
Supplying ssh keys and env variable to container for e2e testing (#851)
77df143 
* Supplying ssh keys and env variable to container for e2e testing

adding missing pkg and sample test file

a minor fix for CI to consume key from correct location

correcting CI faiure

reading SSH_KEY_OPT correctly

code cleanup

restarting CI run

Adding support SSH_KEY_PATH for local test run, no need to set environment vars any more

Adding target for e2e tests (addressing Ritesh's comment)

Fix Admin Cli command to list selected columns for Filesystem Type an… (#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format

adding new test target @test-All

adding inline comment

adding test target to drone script (Addressing Ritesh's comment)

testing out CI failure

adding e2e-test target to pick up at CI using drone script

* restarting CI test
shaominchen pushed a commit that referenced this pull request Jan 11, 2017
@shuklanirdesh82
Supplying ssh keys and env variable to container for e2e testing (#851)
fde8f20 
* Supplying ssh keys and env variable to container for e2e testing

adding missing pkg and sample test file

a minor fix for CI to consume key from correct location

correcting CI faiure

reading SSH_KEY_OPT correctly

code cleanup

restarting CI run

Adding support SSH_KEY_PATH for local test run, no need to set environment vars any more

Adding target for e2e tests (addressing Ritesh's comment)

Fix Admin Cli command to list selected columns for Filesystem Type an… (#845)

* Fix Admin Cli command to list selected columns for Filesystem Type and Disk Format

adding new test target @test-All

adding inline comment

adding test target to drone script (Addressing Ritesh's comment)

testing out CI failure

adding e2e-test target to pick up at CI using drone script

* restarting CI test
@ashahi1 ashahi1 deleted the listFileSystemColumn.ashahi1 branch June 8, 2017 00:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerneltime kerneltime kerneltime approved these changes

@lipingxue lipingxue lipingxue approved these changes

Assignees

@ashahi1 ashahi1

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ashahi1 @kerneltime @lipingxue @vmwclabot