This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Updated documentation for tenant access set command in admin-cli to keep it consistent with the output of the CLI. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharnt
changed the title
shaominchen
suggested changes
Feb 28, 2017
docs/user-guide/admin-cli.md
Outdated
| @@ -390,8 +390,8 @@ usage: vmdkops_admin.py tenant access set [-h] | |||
| [--volume-totalsize Num{MB,GB,TB} - e.g. 2TB] | |||
| --name NAME | |||
| [--volume-maxsize Num{MB,GB,TB} - e.g. 2TB] | |||
| [--allow-create] --datastore | |||
| DATASTORE | |||
| [--allow-create ALLOW_CREATE] | |||
There was a problem hiding this comment.
- How about changing "ALLOW_CREATE" to "True|False" to make it clearer?
- We need to make the same change for line 300.
There was a problem hiding this comment.
As we discussed, we will address the change to make add and set commands consistent separately.
docs/user-guide/admin-cli.md
Outdated
| @@ -401,7 +401,10 @@ optional arguments: | |||
| --name NAME Tenant name | |||
| --volume-maxsize Num{MB,GB,TB} - e.g. 2TB | |||
| Maximum size of the volume that can be created | |||
| --allow-create Allow create and delete on datastore if set to True | |||
| --allow-create ALLOW_CREATE | |||
| Allow create and delete on datastore if set to True; | |||
There was a problem hiding this comment.
We need to make the same change for line 311.
There was a problem hiding this comment.
As we discussed, we will address the change to make add and set commands consistent separately.
tusharnt
force-pushed
the
issue_917.tusharnt
branch
from
7549974
to
86e64e9
Compare
…eep it consistent with the output of the CLI. Addressed Sam's feedback.
tusharnt
force-pushed
the
issue_917.tusharnt
branch
from
eb51362
to
ed397c6
Compare
shaominchen
approved these changes
Feb 28, 2017
| @@ -390,8 +390,8 @@ usage: vmdkops_admin.py tenant access set [-h] | |||
| [--volume-totalsize Num{MB,GB,TB} - e.g. 2TB] | |||
| --name NAME | |||
| [--volume-maxsize Num{MB,GB,TB} - e.g. 2TB] | |||
| [--allow-create] --datastore | |||
| DATASTORE | |||
| [--allow-create Value{True|False} e.g. True] | |||
There was a problem hiding this comment.
Nit: I think we can remove "e.g. True"
There was a problem hiding this comment.
I would prefer to keep it as to keep it consistent with the rest.
| @@ -401,7 +401,10 @@ optional arguments: | |||
| --name NAME Tenant name | |||
| --volume-maxsize Num{MB,GB,TB} - e.g. 2TB | |||
| Maximum size of the volume that can be created | |||
| --allow-create Allow create and delete on datastore if set to True | |||
| --allow-create Value{True|False} - e.g. True | |||
There was a problem hiding this comment.
I would prefer to keep it as to keep it consistent with the rest.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation for tenant access set command in admin-cli to keep it consistent with the output of the CLI.