This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Make sure _DEFAULT created after remove is created with constant UUID #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msterin
reviewed
Mar 3, 2017
esx_service/utils/auth_api.py
Outdated
| description=description, | ||
| vms=vms, | ||
| privileges=privileges) | ||
| if name == auth.DEFAULT_TENANT: |
There was a problem hiding this comment.
I would actually prefer
if name == auth.DEFAULT_TENANT:
tenant_uuid = auth.DEFAULT_TENANT_UUID
else:
tenant_uuid = None
error_msg, tenant = auth_mgr.create_tenant(name=name, ..., tenant_uuid=tenant_uuid)| @@ -683,7 +683,7 @@ def get_vol_path(datastore, tenant_name=None): | |||
|
|
|||
| if tenant_name and not os.path.isdir(path): | |||
| # The mkdir command is used to create "tenant_name" folder inside DOCK_VOLS_DIR on "datastore" | |||
| cmd = "{0} {1}".format(MKDIR_CMD, path) | |||
| cmd = "{0} '{1}'".format(MKDIR_CMD, path) | |||
shaominchen
reviewed
Mar 3, 2017
esx_service/utils/auth_api.py
Outdated
| description=description, | ||
| vms=vms, | ||
| privileges=privileges) | ||
| if name == auth.DEFAULT_TENANT: |
There was a problem hiding this comment.
I'd like to repeat my previous comment - I do think we should handle the tenant uuid inside the create_tenant() API. IMO, uuid should not be handled by the API users. It's the API's responsibility to take care of the appropriate uuids.
If you recall, exposing uuid to the API users has caused multiple unnecessary changes.
There was a problem hiding this comment.
so would you suggest "create_tenant" and "create_default_tenant" APIs, or just put
if name == DEFAULT_TENANT_NAME
uuid = DEFAULT_UUID
else:
uuid = generate_uuidinto the create_tenant ? (I guess the latter, right ?)
There was a problem hiding this comment.
Right. I'm suggesting the latter.
… (issue 986). Fix the issue that volume create fail on a datastore whose name includes spaces (issue 916)..
lipingxue
force-pushed
the
create_default_tenant_with_constant_uuid.liping
branch
from
0d9ca81
to
e1faafc
Compare
lipingxue
force-pushed
the
create_default_tenant_with_constant_uuid.liping
branch
from
e1faafc
to
5276de2
Compare
|
@msterin @shaominchen I have addressed your comments. |
msterin
approved these changes
Mar 3, 2017
shuklanirdesh82
deleted the
create_default_tenant_with_constant_uuid.liping
branch
This was referenced Mar 6, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following
Make sure _DEFAULT created after remove is created with constant UUID(issue 986).
Fix the issue that volume create fails on a datastore whose name includes spaces (issue 916).
Please review it.