Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Rearranging the test execution order #989

Conversation

shuklanirdesh82
Copy link
Contributor

@shuklanirdesh82 shuklanirdesh82 commented Mar 3, 2017

This change was pending on #579. Work has been done on CI side by making sure that vms are not having PVSCSI pre-added and let the driver to add pvscsi as part of volume/vmdk creation.

"TestVolumeCreationFirstTime" is part of e2e-dkrVolDriver-test target and with this PR we are making sure that it is running very first.

Copy link
Contributor

@govint govint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Pls. document CI failure cause.

@shuklanirdesh82
Copy link
Contributor Author

After removing PVSCSI controller from above vms and #989 exposes the volume creation failure for the test TestVolumeCreationFirstTime; which was added as part of #794 (to cover #656 failure case)

https://ci.vmware.run/vmware/docker-volume-vsphere/1477

=== RUN TestVolumeCreationFirstTime

creating volume [abc_1488520428] on VM[192.168.31.176]--- FAIL: TestVolumeCreationFirstTime (21.66s)
	createVolume_test.go:58: 
		Error has occurred [Error response from daemon: create abc_1488520428: Post http://%2Frun%2Fdocker%2Fplugins%2Fvsphere.sock/VolumeDriver.Create: http: ContentLength=36 with Body length 0
		] 
			while creating volume [abc_1488520428] very first time: err -> exit status 1

@govint is going to help further while providing a fix, so I am merging this trivial change.

@shuklanirdesh82 shuklanirdesh82 merged commit 8a3ada8 into vmware-archive:master Mar 3, 2017
@shuklanirdesh82 shuklanirdesh82 deleted the rearrangeE2Etests.shuklanirdesh82 branch March 3, 2017 06:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants