This repository has been archived by the owner on Nov 9, 2020. It is now read-only.
Allow to use latest Docker (v 17.xx and later) in build #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version checking scheme in build.sh was not hanling new Docker major versions well so the build was failing with "Docker 1.8 or later is required". Fixed the version checking scheme to work properly. We probably do not need this at all since Docker 1.7 is failry ancient, but keeping in the code out of pure paranoia.
shuklanirdesh82
approved these changes
Mar 6, 2017
pdhamdhere
reviewed
Mar 6, 2017
| if [ $min_ver -lt 8 ] | ||
| maj_ver=`echo $ver | sed 's/\..*$//'` | ||
| min_ver=`echo $ver | sed 's/[0-9]*\.//' | sed 's/\..*$//'` | ||
| if [ $maj_ver -lt 17 -a $min_ver -lt 8 ] |
There was a problem hiding this comment.
Hmm Is this condition correct? maj_ver < 17 && min_ver < 8? Why?
I think we can get rid of this code altogether and just document.
There was a problem hiding this comment.
yes, this condition means 1.7 and below :-). See description - yes, we can drop it and document or we can leave it and not document - my (paranoid) preference is to leave it to handle the case and not touch any docs.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version checking scheme in build.sh was not handling new Docker major versions (i.e. 17....)
well so the build was failing with "Docker 1.8 or later is required".
Fixed the version checking scheme to work properly.
We probably do not need this at all since Docker version < 1.8 is fairly ancient, but keeping in the code out of pure paranoia.