Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include a 'default' configuration for each resource #203

Open
lucdekens opened this issue Oct 14, 2019 · 4 comments
Open

[Feature] Include a 'default' configuration for each resource #203

lucdekens opened this issue Oct 14, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers in progress The issue is being actively worked on by someone.

Comments

@lucdekens
Copy link
Contributor

lucdekens commented Oct 14, 2019

As discussed in #39 and #101, all resources shall contain a configuration file demonstrating the 'defaults' as taken by vSphere.
The 'defaults' are the values taken by vSphere when no explicit values are specified.

Since the 'defaults' may change between vSphere versions, the configuration shall indicate for which vSphere version it contains the 'defaults'.

@lucdekens
Copy link
Contributor Author

Using this information in the ExportVMHostConfiguration script would seriously lower the number of generated lines.

Just saying :-)

@SimeonGerginov
Copy link
Contributor

Yes I agree and I propose to add each configuration here as a separate comment and then add them to the repository with a single PR. What do you think ?

@lucdekens
Copy link
Contributor Author

Sounds like a plan.

One aspect to consider before doing that is the relation between defaults and the vSphere version.
Some defaults change with the vSphere version.

@SimeonGerginov SimeonGerginov self-assigned this Mar 11, 2020
@SimeonGerginov SimeonGerginov added enhancement New feature or request good first issue Good for newcomers in progress The issue is being actively worked on by someone. labels Mar 11, 2020
@SimeonGerginov SimeonGerginov added this to the 2.2-Consider milestone Apr 24, 2020
@SimeonGerginov
Copy link
Contributor

VMHostNtpSettings DSC Resource default configuration for vSphere versions 6.5, 6.7 and 7.0:

Configuration VMHostNtpSettings_Default_Config {
    Param(
        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [string]
        $Server,

        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [System.Management.Automation.PSCredential]
        $Credential,

        [Parameter(Mandatory = $true)]
        [ValidateNotNullOrEmpty()]
        [string]
        $VMHostName
    )

    Import-DscResource -ModuleName VMware.vSphereDSC

    Node localhost {
        VMHostNtpSettings VMHostNtpSettings {
            Server = $Server
            Credential = $Credential
            Name = $VMHostName
            NtpServer = @()
            NtpServicePolicy = 'Off'
        }
    }
}

@SimeonGerginov SimeonGerginov removed this from the 2.2-Consider milestone Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers in progress The issue is being actively worked on by someone.
Projects
None yet
Development

No branches or pull requests

2 participants