Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resignature of vmfs snapshots #1442

Merged
merged 4 commits into from
May 1, 2019
Merged

Support resignature of vmfs snapshots #1442

merged 4 commits into from
May 1, 2019

Conversation

smazurov
Copy link
Contributor

Added ability (and a test that skips unless there is an available snapshot) to resignature vmfs snapshots. Basically this flow

@vmwclabot
Copy link
Member

@smazurov, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @smazurov

object/host_datastore_system.go Outdated Show resolved Hide resolved
object/host_datastore_system_test.go Outdated Show resolved Hide resolved
@smazurov
Copy link
Contributor Author

smazurov commented May 1, 2019

@dougm typo addressed, nice catch!

@dougm
Copy link
Member

dougm commented May 1, 2019

Thanks @smazurov . Were you able to sign the CLA?

@vmwclabot
Copy link
Member

@smazurov, your company's legal contact has approved your signed contributor license agreement. It will also be reviewed by VMware, but the merge can proceed.

@dougm dougm merged commit fc3f0e9 into vmware:master May 1, 2019
@vmwclabot
Copy link
Member

@smazurov, VMware has approved your signed contributor license agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants