govc: Add capability to add and remove standalone host to/from datacenter.

[bitwisekaizen]

Doesn't look like we have the ability to add or remove a host to a datacenter from govc or from datacenter.go. Perhaps we could have something like this:

 $ govc datacenter.addhost -dc=somedatacenter -hostname=somehost -hostuser=root -hostpassword=password
 $ govc datacenter.removehost -dc=somedatacenter -hostname=somehost

I'm working on this now to support my work on the Terraform vSphere plugin. Would be happy to contribute it back upstream if the usage above looks reasonable to you guys.

[dougm]

Sounds great @gavingray . Maybe stick with the MO type . method name for the cli names, in this case:

The HostSystem.ReconnectHost would be: govc host.reconnect -dc x ...
And HostSystem.DisconnectHost: govc host.disconnect -dc x ...

[bitwisekaizen]

I think that reconnect and disconnect are fundamentally different things that what I'm talking about to do here. AddStandaloneHost is a method on the host folder and Destroy is a method on the ComputeResource. Reconnect and Disconnect are used on a HostSystem. Disconnect leaves the host in the inventory and Reconnect assumes that the HostSystem is in the disconnected state. That said, if you'd like to stick closely with the MO paradigms, it would be something more like this.

$ govc datacenter.addstandalonehost -dc=somedatacenter -hostname=somehost ...
$ govc host.destroy -dc=somedatacenter -hostname=something

I think that "addstandalonehost" is pretty wordy though. I think that "addhost" would probably suffice.

I have most of the work here done on the govmomi side. Will just need to add tests and the proper govc implementation. Just let me know what you think and I'll get a PR out stat!

[dougm]

Ah cool, in that case I'd probably go with "datacenter.host.add" or even just "host.add".

[bitwisekaizen]

Agreed. I like host.add. Will do! Thanks for the feedback!

[pietern]

@bitwisekaizen Hi Gavin, did you end up working on this? If not, somebody else can pick it up.

[bitwisekaizen]

I actually have a changed shelved for this. I got sidetracked for a while, but I should be able to put it up in the next couple of days. Hoping to get more active in the next few weeks.

[pietern]

Thanks for the update.

[dougm]

We have added both 'host.add' (e01555f) and 'cluster.add' (5154339) commands to govc.