Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[govc] Introduce TLSHandshakeTimeout parameter #890

Merged
merged 2 commits into from
Oct 23, 2017
Merged

[govc] Introduce TLSHandshakeTimeout parameter #890

merged 2 commits into from
Oct 23, 2017

Conversation

caglar10ur
Copy link
Contributor

No description provided.

@caglar10ur caglar10ur requested a review from dougm October 23, 2017 22:53
@caglar10ur caglar10ur mentioned this pull request Oct 23, 2017
Closed
dougm
dougm approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm

govc/flags/client.go Outdated
usage := fmt.Sprintf("TLS handshake timeout [%s]", envTLSHandshakeTimeout)
f.DurationVar(&flag.tlsHandshakeTimeout, "tls-handshake-timeout", value, usage)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra blank line :)

@caglar10ur caglar10ur merged commit bfed5ee into vmware:master Oct 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caglar10ur @dougm @vmwclabot