vcsim: workaround xml ns issue with pyvsphere #958
Conversation
| typ, ok := vim25MapType(name) | ||
| if !ok { | ||
| // See TestIssue945, in which case Go does not resolve the namespace and name == "ns1:TraversalSpec" | ||
| // Without this hack, the SelectSet would be all nil's |
There was a problem hiding this comment.
need to take a closer look. feels hacky. seems like we are trimming only vim25: as namespace here:
govmomi/vim25/types/registry.go
Line 38 in 5072cda
There was a problem hiding this comment.
It is a hack, like the comment says. We've only hit this with pyvsphere (not pyvmomi or other clients). I don't want to spend time messing with our fork of the xml package at the moment.
There was a problem hiding this comment.
not the xml fork. just TypeFunc in types/registry.go. If you replace the TrimPrefix with SplitN, it should work as well. or maybe we can have a TypeFunc that only trims vim25, and anther that trims all namespaces.
There was a problem hiding this comment.
Yeah I didn't want to put the hack in the types package. The vim25 check there is valid. But the hack above we shouldn't need at all, as the xml package should be properly resolving the namespace alias.
There was a problem hiding this comment.
oh, i see, there is this: <SOAP-ENV:Body xmlns:ns1="urn:vim25"> missed that.
Fixes #945