Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '-rescan-vmfs' option to host.storage.info #966

Merged
merged 1 commit into from
Dec 19, 2017

Conversation

acortiana
Copy link
Contributor

Add '-refreshvmfs' option to host.storage.info

@vmwclabot
Copy link
Member

@acortiana, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@acortiana, VMware has approved your signed contributor license agreement.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @acortiana ,
The docs say "The RefreshStorageSystem method also performs a VMFS rescan."

http://pubs.vmware.com/vsphere-6-5/index.jsp#com.vmware.wssdk.apiref.doc/vim.host.StorageSystem.html#rescanVmfs

So refresh should actually take care of this, does it not? Or is there another reason to use RescanVmfs directly? And maybe we could mention the reason(s) in the help doc or just a comment.

Would also prefer the flag to be named rescan-vmfs rather than rescanvmfs, ok with you?

@acortiana
Copy link
Contributor Author

You are right, Doug. RefreshStorageSystem also performs a VMFS rescan.
I implemented this feature because I didn't know this.
Maybe this feature can be useful: in the GUI it's possible to do a VMFS rescan by itself and I think that this is faster than doing a full RefreshStorageSystem call.
No problem for the name of the flag: rescan-vmfs is ok.

@dougm
Copy link
Member

dougm commented Dec 18, 2017

@acortiana ok sounds good, I didn't know the GUI had that option. If you can just rename the flag that'd be great.

@acortiana acortiana changed the title Add '-refreshvmfs' option to host.storage.info Add '-rescan-vmfs' option to host.storage.info Dec 18, 2017
@dougm dougm merged commit 2892ed5 into vmware:master Dec 19, 2017
@dougm
Copy link
Member

dougm commented Dec 19, 2017

Thanks @acortiana !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants