Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ping target API #3662

Merged
merged 1 commit into from Nov 23, 2017
Merged

Refactor ping target API #3662

merged 1 commit into from Nov 23, 2017

Conversation

ywk253100
Copy link
Contributor

No description provided.

@ywk253100
Refactor ping target API
46fced7 
Merge ping target API by ID into ping target API
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 56.215% when pulling 46fced7 on ywk253100:171122_ping_endpoint into 53dbe74 on vmware:ping_endpoint.

reasonerjt
reasonerjt approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ywk253100 ywk253100 merged commit 03e13af into goharbor:ping_endpoint Nov 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reasonerjt reasonerjt reasonerjt approved these changes

Assignees

@reasonerjt reasonerjt

Labels
cla-not-required target/vic-1.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ywk253100 @coveralls @reasonerjt @vmwclabot