Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyVmomi should never extend base or core types #69

Open
hartsock opened this issue Jun 26, 2014 · 0 comments
Open

pyVmomi should never extend base or core types #69

hartsock opened this issue Jun 26, 2014 · 0 comments

Comments

@hartsock
Copy link
Member

This VmomiSupport.py#L179 is considered extremely bad form in the Python community. Extension of core types ties the code to interpreter internals that may not be intended for exposure. This is akin to using a hidden API and should be avoided or at least isolated so that potential damage is easier to control.

Rewrite the code so that the class Link is not needed anymore or so that Link can operate without directly extending a core type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant