This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Fix unescaped characters in Datastore URLs #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URI.escape doesn't escape some characters that are valid in datacenter, datastore and folder names. Eg. &, ?, =, (, ). This can lead to invalid URLs being generated. Using URI.encode_www_form_component should correctly escape these characters.
|
Thanks so much for your contribution! 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URI.escape doesn't escape some characters that are valid in datacenter,
datastore and folder names. Eg. &, ?, =, (, ). This can lead to invalid
URLs being generated.
Using URI.encode_www_form_component should correctly escape these
characters.