Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Default plugin selection ignored #3

Closed
dmc5179 opened this issue Jun 17, 2020 · 3 comments
Closed

Default plugin selection ignored #3

dmc5179 opened this issue Jun 17, 2020 · 3 comments

Comments

@dmc5179
Copy link

dmc5179 commented Jun 17, 2020

WHen running the safekeeping application the prompts for S3, FileStorage, and NFSStorage all show a default of false. This implies that pressing enter should be the same as typing 'false' and pressing enter. When I just press enter, I'm then prompted for the settings of each plugin. Those prompts should be skipped if the default is being applied. Here is the output where I just pressed enter at each of the 3 plugin prompt defaults for false:

AMAZONS3
Activate the Plugin [false]
S3 Region [us-west-2]
S3 Backet Name/folder []
S3 Access Key []
S3 Secret Key <hidden>
	Repeat password:     

FILESTORAGE
Activate the Plugin [false]
File Archive directory [/opt/vmware/safekeeping/archive]

NFSSTORAGE
Activate the Plugin [false]
NFS Absolute Path (server:/Export) [localhost:/vol]
User UID [0]
User GID [0]
Max number of retry [5]
Use port <1024 [false]
Use portmap port <1024 [false]
NFS Timeout [20]
@dmc5179
Copy link
Author

dmc5179 commented Jun 17, 2020

Looks like even if you type false and press enter, it still asks you:

MAZONS3
Activate the Plugin [false]false
S3 Region [us-west-2]
S3 Backet Name/folder []

@mdaneri
Copy link
Contributor

mdaneri commented Jun 17, 2020

I know it's annoying :)
I was lazy when I wrote this part of the code. Thanks for the feedback

@mdaneri mdaneri closed this as completed Jul 15, 2020
@dmc5179
Copy link
Author

dmc5179 commented Jul 16, 2020

I'll see if I can fix it and submit a PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants