Fix sk8 to pass conformance #15
Conversation
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
There was a problem hiding this comment.
Hi @yastij,
This is great! Thank you! I just had a few nits to pick, but other than that, looks good. Great job!
cc @clintkitson
| @@ -590,7 +590,7 @@ turn_up() { | |||
| if [ "${EXTERNAL}" = "true" ]; then | |||
| printf "waiting for cluster to finish coming online... " | |||
| i=0 && while true; do | |||
| [ "${i}" -ge 100 ] && { error "timed out waiting for cluster" 1; return; } | |||
| [ "${i}" -ge 110 ] && { error "timed out waiting for cluster" 1; return; } | |||
There was a problem hiding this comment.
Hi @yastij,
Hmmm, a loop iteration count of 100 equals 5 minutes. Should we just double it to 200 for 10 minutes? Any reason not to?
There was a problem hiding this comment.
I think we'll be fine with this. I can revisit if not enough, but nothing against.
| @@ -2574,8 +2574,7 @@ EOF | |||
| fi | |||
|
|
|||
| cat <<EOF >/etc/default/kubelet | |||
| KUBELET_OPTS="--allow-privileged \\ | |||
| --client-ca-file='${TLS_CA_CRT}'${EXT_CLOUD_PROVIDER_OPTS} \\ | |||
| KUBELET_OPTS="--client-ca-file='${TLS_CA_CRT}'${EXT_CLOUD_PROVIDER_OPTS} \\ | |||
There was a problem hiding this comment.
Hi @yastij,
Any negative effect(s) on versions of Kubernetes built before this commit?
There was a problem hiding this comment.
this should be fine as it already defaults to true to supported version see kubernetes/kubernetes#63442
|
Hi @yastij, One last note -- there are five locations in |
|
@akutz - I think that the others are fine, it's mostly LBs that take time |
This change updates sk8 to pass conformance, change is minimal and commits are reviewable separately
cc @akutz