Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REJECT action support in vcd_nsxt_firewall #1240

Merged
merged 6 commits into from
Jun 13, 2024

Conversation

Didainius
Copy link
Collaborator

@Didainius Didainius commented Mar 26, 2024

This PR starts using ActionValue (added here) instead of Action field and adds support for REJECT
Closes #1211

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius marked this pull request as ready for review April 10, 2024 10:23
Copy link
Collaborator

@adambarreiro adambarreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@lvirbalas lvirbalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!!

Signed-off-by: Dainius Serplis <dserplis@vmware.com>
go.mod Outdated Show resolved Hide resolved
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
Signed-off-by: Dainius Serplis <dserplis@vmware.com>
@Didainius Didainius merged commit ce48b62 into vmware:main Jun 13, 2024
3 checks passed
@Didainius Didainius deleted the pr-firewall-rejection branch June 13, 2024 13:29
@Didainius Didainius restored the pr-firewall-rejection branch June 14, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vcd_nsxt_firewall resource issues: logging state not being applied and missing 'REJECT' support
4 participants