Add storage_profile_id to vcd_catalog and introduce datasource vcd_storage_profile
#602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvirbalas
requested changes
Dec 8, 2020
lvirbalas
reviewed
Dec 8, 2020
lvirbalas
reviewed
Dec 8, 2020
lvirbalas
requested changes
Dec 8, 2020
vcd/resource_vcd_catalog.go
Outdated
| if storageProfileId != "" { | ||
| storageProfileReference, err := adminOrg.GetStorageProfileReferenceById(storageProfileId, false) | ||
| if err != nil { | ||
| return fmt.Errorf("couuld not proces storage profile '%s': %s", storageProfileId, err) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("couuld not proces storage profile '%s': %s", storageProfileId, err) | |
| return fmt.Errorf("could not process Storage Profile '%s': %s", storageProfileId, err) |
lvirbalas
requested changes
Dec 8, 2020
lvirbalas
requested changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598 ,
This PR adds
storage_profile_idattribute tovcd_catalogresource and datasource (for create and update)Additionally it introduces
vcd_storage_profiledatasource for storage profile ID lookup.It also allows to change
descriptionfield forvcd_catalogNote. Acceptance tests passed on at least one version (also
VCD_TEST_ORG_USER=1 go test -timeout 30m -v -tags "org catalog")