Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Photon 2.0 Bug fix to properly identify VMware Photon OS. #16

Merged
merged 1 commit into from May 11, 2018

Conversation

ankurdh
Copy link

@ankurdh ankurdh commented May 10, 2018

In the Photon 2.0 release, /etc/photon-release doesn't have VMware Photon Linux anymore. It contains:

root@photon-2.0-ankurh [ ~ ]# cat /etc/photon-release
VMware Photon OS 2.0

Fixing the code to grep for only VMware Photon instead of VMware Photon Linux. Other tiny changes include:

Testing output:

 huralikoppia@huralikoppia-m03 ~/code/vagrant-guests-photon $ rspec                                                                                                                      ✔  5058  15:27:40
[Coveralls] Set up the SimpleCov formatter.
[Coveralls] Using SimpleCov's default settings.
..........

Finished in 0.01164 seconds
10 examples, 0 failures
[Coveralls] Outside the CI environment, not sending data.

In the Photon 2.0 release, /etc/photon-release doesn't have 'VMware Photon Linux' anymore. It contains:

root@photon-2.0-ankurh [ ~ ]# cat /etc/photon-release
VMware Photon OS 2.0
PHOTON_BUILD_NUMBER=304b817

Fixing the code to grep for only VMware Photon instead of VMware Photon Linux.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.817% when pulling 4e8bbed on ankurdh:vmw_photon_2_readiness into 3c41310 on vmware:master.

@frapposelli frapposelli merged commit aa71e0b into vmware-archive:master May 11, 2018
@frapposelli
Copy link
Contributor

Thanks @ankurdh just pushed version v1.0.5 to rubygems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants