This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
VP-2791,VP-2709,VP-2707 Update nic #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VP-2791:[VcdCLI]UPdate nic
VP-2707:[VcdCLI]List media file in VDC
VP-2709:[VcdCLI]Remove href from insert-cd and eject-cd command
Above functionalities are part of the CLN. It can be called from command
line as :
vcd vm update-nic vapp1 vm1
--adapter-type VMXNET3
--primary
--connect
--network network_name
--ip-address-mode MANUAL
--ip-address 192.168.1.10
vcd vdc list-media
Testing Done:
Test method test_0010_list_media in vdc_tests.py and
test_0115_update_nic in vm_tests.py is added.
kkkothari
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
shashim22
reviewed
Jul 31, 2019
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @kkkothari and @shashim22)
added 2 commits
July 31, 2019 13:36
VP-2791:[VcdCLI]UPdate nic VP-2707:[VcdCLI]List media file in VDC VP-2709:[VcdCLI]Remove href from insert-cd and eject-cd command Above functionalities are part of the CLN. It can be called from command line as : vcd vm update-nic vapp1 vm1 --adapter-type VMXNET3 --primary --connect --network network_name --ip-address-mode MANUAL --ip-address 192.168.1.10 vcd vdc list-media Testing Done: Test method test_0010_list_media in vdc_tests.py and test_0115_update_nic in vm_tests.py is added.
VP-2791:[VcdCLI]UPdate nic
VP-2707:[VcdCLI]List media file in VDC
VP-2709:[VcdCLI]Remove href from insert-cd and eject-cd command
Above functionalities are part of the CLN. It can be called from command
line as :
vcd vm update-nic vapp1 vm1
--adapter-type VMXNET3
--primary
--connect
--network network_name
--ip-address-mode MANUAL
--ip-address 192.168.1.10
vcd vdc list-media
Testing Done:
Test method test_0010_list_media in vdc_tests.py and
test_0115_update_nic in vm_tests.py is added.
shashim22
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status:
|
Missing "update-nic" in the documentation here: http://vmware.github.io/vcd-cli/commands.html |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VP-2791:[VcdCLI]UPdate nic
VP-2707:[VcdCLI]List media file in VDC
VP-2709:[VcdCLI]Remove href from insert-cd and eject-cd command
Above functionalities are part of the CLN. It can be called from command
line as :
vcd vm update-nic vapp1 vm1
--adapter-type VMXNET3
--primary
--connect
--network network_name
--ip-address-mode MANUAL
--ip-address 192.168.1.10
vcd vdc list-media
Testing Done:
Test method test_0010_list_media in vdc_tests.py and
test_0115_update_nic in vm_tests.py is added.
This change is