Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdk-core: credentials for named databases and ingesters #3225

Closed
DeltaMichael opened this issue Mar 18, 2024 · 0 comments
Closed

vdk-core: credentials for named databases and ingesters #3225

DeltaMichael opened this issue Mar 18, 2024 · 0 comments

Comments

@DeltaMichael
Copy link
Contributor

Prerequisites

#3223
#3224

Overview

Pre-loading database or ingesters requires sensitive configs, like credentials. These should be added in the initialize job hook and fetched either from the secrets api or config.ini.

@hookimpl
  def vdk_initialize(self, context: CoreContext) -> None:
      context.register_db(key="default", type="oracle", host="localhost", port="1521", sid="free")
      context.register_db(key="oracle_1", type="oracle", host="http://some_host_whatever/", port="1522", sid="not_free")
      context.register_db(key="impala_1", type="impala", host="http://impala_host/", database="mydatabase")

@hookimpl
  def initialize_job(self, context: JobContext) -> None:
      context.add_credentials("oracle1", context.core_context.config.get_value("oracle_1", "username"), context.core_context.config.get_value("oracle_1", "password"))

We should fetch credentials from secrets, but we should also be able to configure them in config.ini

Acceptance criteria

  1. Propose a way to configure credentials for pre-loaded databases/ingesters
  2. Implement proposal, or open a separate implementation ticket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant