New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for invalid mails upon job deployment #797
Comments
Assign it me I, will add the new feature |
I assigned the issue to you, Abdullium Thanks and looking forward to your changes. |
Sorry I think this requires software engineering skills, |
We have multiple examples - https://github.com/vmware/versatile-data-kit/tree/main/examples They require CLI knowledge, some python (at least Python and quickstart-vdk needs to be installed locally) and SQL. Is that something you are comfortable with? What kind of data analysis do you usually do? |
I can do exploratory data analysis checkout my profile Thank you i wil he k it out |
Hi @Abdullium, Have you been able to work on this? If you need help with anything do not hesitate to write here or in the slack channel. Or just write an email. |
Hi @tozka , If the issue is still open I would like to work on it. |
Hi @akorkos Yes, it's still open. Please feel free to assign it to yourself and work on it. Join our slack channel as well so it is easier to ask questions - https://github.com/vmware/versatile-data-kit#contacts |
Triaged. We will keep it, as being a First good issue . |
What is the feature request? What problem does it solve?
As employees leave the organization/company or users change mails , eventually the notification list configured for the job would start containing a lot of invalid mails. This causes issues with SMTP relay (e.g postfix) which could be buffering all invalid requests until the queu is full, which cause all mails coming for all jobs to be blocked.
To reduce the chance of such scenario happening and to keep configuration clean and correct, it might be good idea to provide (optional) validation when a user tries to deployed a data job
Suggested solution
A clear and concise description of what you want to happen.
We can add a new option (NOTIFICATION_MAIL_VERIFY = True/False).
If it's configured issue http://www.smtp-server.com/simple_mail_verifying.htm to verify the mail .
We can also use something like this https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/src/vdk/internal/builtin_plugins/notification/notification_base.py#L113
But there's concern that this might cause issues (since it's RCPT request which may be queued similarly by mail relay).
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: