Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid mails upon job deployment #797

Open
antoniivanov opened this issue Apr 11, 2022 · 9 comments
Open

Check for invalid mails upon job deployment #797

antoniivanov opened this issue Apr 11, 2022 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@antoniivanov
Copy link
Collaborator

What is the feature request? What problem does it solve?

As employees leave the organization/company or users change mails , eventually the notification list configured for the job would start containing a lot of invalid mails. This causes issues with SMTP relay (e.g postfix) which could be buffering all invalid requests until the queu is full, which cause all mails coming for all jobs to be blocked.

To reduce the chance of such scenario happening and to keep configuration clean and correct, it might be good idea to provide (optional) validation when a user tries to deployed a data job

Suggested solution
A clear and concise description of what you want to happen.

We can add a new option (NOTIFICATION_MAIL_VERIFY = True/False).

If it's configured issue http://www.smtp-server.com/simple_mail_verifying.htm to verify the mail .
We can also use something like this https://github.com/vmware/versatile-data-kit/blob/main/projects/vdk-core/src/vdk/internal/builtin_plugins/notification/notification_base.py#L113
But there's concern that this might cause issues (since it's RCPT request which may be queued similarly by mail relay).

Additional context
Add any other context or screenshots about the feature request here.

@antoniivanov antoniivanov added enhancement New feature or request good first issue Good for newcomers labels Apr 11, 2022
@Abdullium
Copy link

Assign it me I, will add the new feature

@antoniivanov
Copy link
Collaborator Author

I assigned the issue to you, Abdullium

Thanks and looking forward to your changes.

@Abdullium Abdullium removed their assignment Aug 9, 2022
@Abdullium
Copy link

I assigned the issue to you, Abdullium

Thanks and looking forward to your changes.

Sorry I think this requires software engineering skills,
do you know any projects which require data analysis

@antoniivanov
Copy link
Collaborator Author

I assigned the issue to you, Abdullium
Thanks and looking forward to your changes.

Sorry I think this requires software engineering skills, do you know any projects which require data analysis

We have multiple examples - https://github.com/vmware/versatile-data-kit/tree/main/examples
We'd like to extend them and add new ones. Would that type of work be interesting for you?

They require CLI knowledge, some python (at least Python and quickstart-vdk needs to be installed locally) and SQL.
You can try out one of the examples for yourself and see.

Is that something you are comfortable with? What kind of data analysis do you usually do?

@Abdullium
Copy link

I assigned the issue to you, Abdullium
Thanks and looking forward to your changes.

Sorry I think this requires software engineering skills, do you know any projects which require data analysis

We have multiple examples - https://github.com/vmware/versatile-data-kit/tree/main/examples We'd like to extend them and add new ones. Would that type of work be interesting for you?

They require CLI knowledge, some python (at least Python and quickstart-vdk needs to be installed locally) and SQL. You can try out one of the examples for yourself and see.

Is that something you are comfortable with? What kind of data analysis do you usually do?

I can do exploratory data analysis checkout my profile

Thank you i wil he k it out

@antoniivanov
Copy link
Collaborator Author

Hi @Abdullium,

Have you been able to work on this? If you need help with anything do not hesitate to write here or in the slack channel. Or just write an email.

@akorkos
Copy link

akorkos commented Jan 25, 2023

Hi @tozka ,

If the issue is still open I would like to work on it.

@antoniivanov
Copy link
Collaborator Author

Hi @akorkos

Yes, it's still open. Please feel free to assign it to yourself and work on it.

Join our slack channel as well so it is easier to ask questions - https://github.com/vmware/versatile-data-kit#contacts

@sabadzhiev
Copy link

Triaged. We will keep it, as being a First good issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants