Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in gsgdt 0.1.3 #1

Closed
bjorn3 opened this issue Apr 4, 2021 · 3 comments
Closed

Breaking change in gsgdt 0.1.3 #1

bjorn3 opened this issue Apr 4, 2021 · 3 comments

Comments

@bjorn3
Copy link

bjorn3 commented Apr 4, 2021

This causes rustc to fail to compile when updating from gsgdt 0.1.2.

error[E0599]: no function or associated item named `new` found for struct `gsgdt::Node` in the current scope
  --> /home/bjorn/Projects/rust/compiler/rustc_mir/src/util/generic_graph.rs:59:11
   |
59 |     Node::new(stmts, label, title, style)
   |           ^^^ function or associated item not found in `gsgdt::Node`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0599`.
error: could not compile `rustc_mir`
@MabezDev
Copy link

MabezDev commented Aug 3, 2021

Just ran into this - the version should be yanked and released as 0.2.0?

@WilliamVenner
Copy link

WilliamVenner commented Dec 31, 2021

Should be yanked and bumped to 1.0.0.

Alternatively just deprecate the new function and alias it to the new function.

@vn-ki
Copy link
Owner

vn-ki commented Jan 2, 2022

I have yanked 0.1.3. I don't have the bandwidth to work on this rn so won't be releasing a new version. If that is enough, can you close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants