Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working latest Epi (12.4.2) #8

Closed
Dandroid5000 opened this issue Mar 23, 2022 · 10 comments
Closed

Not working latest Epi (12.4.2) #8

Dandroid5000 opened this issue Mar 23, 2022 · 10 comments

Comments

@Dandroid5000
Copy link

Hi,
I have just updated the Epi packages (EPiServer.CMS.Core -> 12.4.2 and EPiServer.Framework -> 12.4.2) and am now getting the following exception when trying to render and resize an image.

System.MissingMethodException: Method not found: 'System.Threading.Tasks.Task1<SixLabors.ImageSharp.Formats.IImageFormat> SixLabors.ImageSharp.Image.DetectFormatAsync(SixLabors.ImageSharp.Configuration, System.IO.Stream)'. at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.ProcessRequestAsync(HttpContext context, IImageResolver sourceImageResolver, ImageContext imageContext, IDictionary2 commands)
at System.Runtime.CompilerServices.AsyncMethodBuilderCore.Start[TStateMachine](TStateMachine& stateMachine)
at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.ProcessRequestAsync(HttpContext context, IImageResolver sourceImageResolver, ImageContext imageContext, IDictionary`2 commands)
at SixLabors.ImageSharp.Web.Middleware.ImageSharpMiddleware.Invoke(HttpContext context)
at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

Please let me know if there is anything I might be doing wrong or if you need any more info.
Cheers
Dan

@Dandroid5000
Copy link
Author

Further, just pionting out that EPiServer.CMS.Core 12.4.2 updates the dependeny on SixLabors.ImageSharp (>= 1.0.4 && < 2.0.0) to (>= 2.0.0 && < 3.0.0)

@vnbaaij
Copy link
Owner

vnbaaij commented Mar 28, 2022

It looks like ImageSharp 2.0 (which is dependency of 12.4.2) does not work with ImageSharp.Web 1.0.5 (latest released version) If this is confirmed (I've asked ImageSharp author), we will need to wait until ImageSharp.Web 2.0 is released.
I've made preparations for this in the v2 branch. As indicated by the number, this will be a next major version targeting .NET 6.

@Dandroid5000
Copy link
Author

Ok, thanks for confirming.
So there will be no fix targeting. NET 5? We have a number of other dependencies stuck in .NET 5, including some Episerver packages, so it would good to know.
Thanks again

@vnbaaij
Copy link
Owner

vnbaaij commented Mar 29, 2022

James confirmed ImageSharp 2.0 does not work with ImageSharp.Web 1.5.
Targeting both .NET 5 and .NET 6 will be hard, I think (because of the changes they made with 12.4.2). Besides that, .NET 5 is out of support in less than 2 months (May 8th). I feel like everyone else should step up (including Optimizely) instead of me backporting stuff...

@vnbaaij
Copy link
Owner

vnbaaij commented Mar 29, 2022

Just tried it with the ImageSharp.Web 2.0 alpha and can confirm it works on .NET 6!
image

@DrewNull
Copy link

DrewNull commented Apr 6, 2022

Hey peeps, I created a bug report on World here:
https://world.optimizely.com/forum/developer-forum/Problems-and-bugs/Thread-Container/2022/4/episerver-cms-core-12-4-2-breaks-imagesharp/

Hopefully we can get some traction. Vincent thank you for putting this package together and trying to get it to work!

@Rrydh
Copy link

Rrydh commented Apr 22, 2022

SixLabors just released v2.0.0 of ImageSharp.Web

@vnbaaij
Copy link
Owner

vnbaaij commented Apr 22, 2022

Version 2.0.0 has just been uploaded to Optimizely. Should be available soon

@vnbaaij vnbaaij closed this as completed Apr 22, 2022
@evest
Copy link

evest commented Apr 22, 2022

v2 is now on the feed.

@vnbaaij
Copy link
Owner

vnbaaij commented Apr 22, 2022

Thanks Steve! All is well, I hope?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants