Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

City names with space are incorrectly modified #76

Closed
vnegi10 opened this issue Jan 3, 2024 · 0 comments · Fixed by #77
Closed

City names with space are incorrectly modified #76

vnegi10 opened this issue Jan 3, 2024 · 0 comments · Fixed by #77
Labels
bug Something isn't working

Comments

@vnegi10
Copy link
Owner

vnegi10 commented Jan 3, 2024 

julia> WeatherReport.fix_input_name("The Hague")
"The hague"

This causes the city to not be found since the database contains 'The Hague' as the name.

julia> plot_hourly_rain("The Hague", days = 3)
ERROR: Coordinates for city not found!
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
@vnegi10 vnegi10 added the bug Something isn't working label Jan 3, 2024
@vnegi10 vnegi10 mentioned this issue Jan 3, 2024
Merged
@vnegi10 vnegi10 linked a pull request Jan 3, 2024 that will close this issue
76 city names with space #77
Merged
vnegi10 referenced this issue Jan 3, 2024
@vnegi10
76 city names with space (#77)
bc0a426 
* Update city name logic

* Bump version

* Test city name with space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

76 city names with space vnegi10/WeatherReport.jl
1 participant
@vnegi10